Bug 308389 – [IFC] Inflated glyph overflow leads to line shifts when paginated

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[alan]

see bug 308087

[alan]

Created attachment 478434 [details]
Patch

[Claudio Saavedra]

Comment on attachment 478434 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=478434&action=review

> LayoutTests/platform/glib/fast/repaint/emoji-glyph-overflow-repaint-fail-expected.txt:5
> +  (rect 8 -5 784 13)
> +  (rect 8 -5 784 13)
> +  (rect 0 -5 800 5)

Not really necessary apparently? https://ews-build.s3-us-west-2.amazonaws.com/GTK-WK2-Tests-EWS/478434-120465-repeat-failures/fast/repaint/emoji-glyph-overflow-repaint-fail-diff.txt

[alan]

Created attachment 478435 [details]
Patch

[alan]

(In reply to Claudio Saavedra from comment #2)
> Comment on attachment 478434 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=478434&action=review
> 
> > LayoutTests/platform/glib/fast/repaint/emoji-glyph-overflow-repaint-fail-expected.txt:5
> > +  (rect 8 -5 784 13)
> > +  (rect 8 -5 784 13)
> > +  (rect 0 -5 800 5)
> 
> Not really necessary apparently?
> https://ews-build.s3-us-west-2.amazonaws.com/GTK-WK2-Tests-EWS/478434-120465-
> repeat-failures/fast/repaint/emoji-glyph-overflow-repaint-fail-diff.txt

I wonder what makes it platform specific. Anyway will rebaseline it before landing. Thank you.

[alan]

Created attachment 478436 [details]
[fast-cq]Patch

[alan]

> I wonder what makes it platform specific. Anyway will rebaseline it before  landing. Thank you.
Nope, not platform specific. It's simply not needed.

[Antti Koivisto]

Comment on attachment 478436 [details]
[fast-cq]Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=478436&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLine.h:153
> +            uint8_t bottom: 3 { 0 };

: placement!

[EWS]

Committed 308037@main (b7dcd15f16d4): <https://commits.webkit.org/308037@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 478436 [details].

[Radar WebKit Bug Importer]

<rdar://problem/170975010>