Bug 30834 – Web Inspector: Initial revision of the Timeline grid.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Initial revision with imagery.

[Pavel Feldman]

Created attachment 41980 [details]
[IMAGE] Present timeline looks

[Pavel Feldman]

Created attachment 41981 [details]
[PATCH] The patch

[Timothy Hatcher]

Comment on attachment 41981 [details]
[PATCH] The patch

> +    _toggleTimelineButtonClick: function()

Better named _toggleTimelineButtonClicked.


> +        iconElement.style.setProperty("background-position-y", this._record.iconNumber * 12 + "px");

You should make this based on a classname.

[Timothy Hatcher]

(In reply to comment #3)
> (From update of attachment 41981 [details])
> > +    _toggleTimelineButtonClick: function()
> 
> Better named _toggleTimelineButtonClicked.
> 
> 
> > +        iconElement.style.setProperty("background-position-y", this._record.iconNumber * 12 + "px");
> 
> You should make this based on a classname.

The classnames you make for the colored dots should just be loading, scripting, rendering, other. The category names.

[Pavel Feldman]

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 41981 [details] [details])
> > > +    _toggleTimelineButtonClick: function()
> > 
> > Better named _toggleTimelineButtonClicked.
> > 

Done.

> > 
> > > +        iconElement.style.setProperty("background-position-y", this._record.iconNumber * 12 + "px");
> > 
> > You should make this based on a classname.
> 
> The classnames you make for the colored dots should just be loading, scripting,
> rendering, other. The category names.

Done.

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/English.lproj/localizedStrings.js
	M	WebCore/WebCore.gypi
	M	WebCore/inspector/front-end/AbstractTimelinePanel.js
	A	WebCore/inspector/front-end/Images/timelineBarBlue.png
	A	WebCore/inspector/front-end/Images/timelineBarGray.png
	A	WebCore/inspector/front-end/Images/timelineBarGreen.png
	A	WebCore/inspector/front-end/Images/timelineBarOrange.png
	A	WebCore/inspector/front-end/Images/timelineBarPurple.png
	A	WebCore/inspector/front-end/Images/timelineBarRed.png
	A	WebCore/inspector/front-end/Images/timelineBarYellow.png
	A	WebCore/inspector/front-end/Images/timelineCheckmarks.png
	A	WebCore/inspector/front-end/Images/timelineDots.png
	M	WebCore/inspector/front-end/ResourcesPanel.js
	M	WebCore/inspector/front-end/TimelineAgent.js
	M	WebCore/inspector/front-end/TimelinePanel.js
	M	WebCore/inspector/front-end/inspector.css
Committed r50203