Bug 30829 - [chromium] expose a method to access memory usage information in ChromiumBridge
Summary: [chromium] expose a method to access memory usage information in ChromiumBridge
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-27 11:29 PDT by anton muhin
Modified: 2009-10-29 11:06 PDT (History)
3 users (show)

See Also:

Attachments
First take (1.42 KB, patch)
2009-10-27 11:32 PDT, anton muhin 		no flags Details | Formatted Diff | Diff
2nd try (6.54 KB, patch)
2009-10-28 17:02 PDT, anton muhin 		no flags Details | Formatted Diff | Diff
2nd try (for real) (1.53 KB, patch)
2009-10-28 17:06 PDT, anton muhin 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description anton muhin 2009-10-27 11:29:00 PDT 
Let's expose a method to access memory usage information via ChromiumBridge (to be used by WebKit and DOM bindings).

Dependency for http://codereview.chromium.org/332010/show
Comment 1 anton muhin 2009-10-27 11:32:54 PDT 
Created attachment 41968 [details]
First take
Comment 2 Eric Seidel (no email) 2009-10-28 15:03:17 PDT 
The ChangeLog really doesn't explain at all what this is for, making it difficult to review.
Comment 3 anton muhin 2009-10-28 17:02:07 PDT 
Created attachment 42069 [details]
2nd try

Is it enough or still too brief?
Comment 4 anton muhin 2009-10-28 17:06:51 PDT 
Created attachment 42070 [details]
2nd try (for real)

Sorry, too big diff in previous patch
Comment 5 Eric Seidel (no email) 2009-10-29 10:37:29 PDT 
I still don't understand why WebCore needs this information?  about:memory is implemented up in Chromium.  For the inspector maybe?  Except you're never using this function anywhere...
Comment 6 Eric Seidel (no email) 2009-10-29 10:39:02 PDT 
I looked at the chromium code review and it was no more clear there what this is for.  There isn't a code.google.com issue mentioned there as far as I can tell.
Comment 7 WebKit Commit Bot 2009-10-29 10:42:24 PDT 
Comment on attachment 42070 [details]
2nd try (for real)

Clearing flags on attachment: 42070

Committed r50283: <http://trac.webkit.org/changeset/50283>
Comment 8 WebKit Commit Bot 2009-10-29 10:42:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 anton muhin 2009-10-29 11:06:17 PDT 
(In reply to comment #6)
> I looked at the chromium code review and it was no more clear there what this
> is for.  There isn't a code.google.com issue mentioned there as far as I can
> tell.

Eric, sorry I didn't explain it in more details.

I need to access info about memory used to force V8's GC when the usage is too high (details are more involved, if you're curious I could cc you on CLs to follow).