RESOLVED FIXED 30829
[chromium] expose a method to access memory usage information in ChromiumBridge 
https://bugs.webkit.org/show_bug.cgi?id=30829
Summary [chromium] expose a method to access memory usage information in ChromiumBridge
anton muhin
Reported 2009-10-27 11:29:00 PDT
Let's expose a method to access memory usage information via ChromiumBridge (to be used by WebKit and DOM bindings). Dependency for http://codereview.chromium.org/332010/show
Attachments
First take (1.42 KB, patch)
2009-10-27 11:32 PDT, anton muhin 		no flags
DetailsFormatted DiffDiff
2nd try (6.54 KB, patch)
2009-10-28 17:02 PDT, anton muhin 		no flags
DetailsFormatted DiffDiff
2nd try (for real) (1.53 KB, patch)
2009-10-28 17:06 PDT, anton muhin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
anton muhin
Comment 1 2009-10-27 11:32:54 PDT
Created attachment 41968 [details] First take
Eric Seidel (no email)
Comment 2 2009-10-28 15:03:17 PDT
The ChangeLog really doesn't explain at all what this is for, making it difficult to review.
anton muhin
Comment 3 2009-10-28 17:02:07 PDT
Created attachment 42069 [details] 2nd try Is it enough or still too brief?
anton muhin
Comment 4 2009-10-28 17:06:51 PDT
Created attachment 42070 [details] 2nd try (for real) Sorry, too big diff in previous patch
Eric Seidel (no email)
Comment 5 2009-10-29 10:37:29 PDT
I still don't understand why WebCore needs this information? about:memory is implemented up in Chromium. For the inspector maybe? Except you're never using this function anywhere...
Eric Seidel (no email)
Comment 6 2009-10-29 10:39:02 PDT
I looked at the chromium code review and it was no more clear there what this is for. There isn't a code.google.com issue mentioned there as far as I can tell.
WebKit Commit Bot
Comment 7 2009-10-29 10:42:24 PDT
Comment on attachment 42070 [details] 2nd try (for real) Clearing flags on attachment: 42070 Committed r50283: <http://trac.webkit.org/changeset/50283>
WebKit Commit Bot
Comment 8 2009-10-29 10:42:28 PDT
All reviewed patches have been landed. Closing bug.
anton muhin
Comment 9 2009-10-29 11:06:17 PDT
(In reply to comment #6) > I looked at the chromium code review and it was no more clear there what this > is for. There isn't a code.google.com issue mentioned there as far as I can > tell. Eric, sorry I didn't explain it in more details. I need to access info about memory used to force V8's GC when the usage is too high (details are more involved, if you're curious I could cc you on CLs to follow).
Note You need to log in before you can comment on or make changes to this bug.