Bug 30826 - REGRESSION: svn-apply exits(1) when applying a patch with a file add
Summary: REGRESSION: svn-apply exits(1) when applying a patch with a file add
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 29622
  Show dependency tree / graph
 
Reported: 2009-10-27 10:08 PDT by Eric Seidel (no email)
Modified: 2009-10-27 10:38 PDT (History)
2 users (show)

See Also:

Attachments
Patch v1 (3.52 KB, patch)
2009-10-27 10:30 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-10-27 10:08:54 PDT 
svn-apply git add is failing for the commit-queue

I believe the problem is that svn-apply should be run with a CWD of the root of the repository.  There is probably a second bug that svn-apply needs to know how to chdir itself to the root of the respository when running in git mode.
Comment 1 Eric Seidel (no email) 2009-10-27 10:26:40 PDT 
This was caused by a bad patch for bug 29622.  I'll post a fix in a sec.
Comment 2 Eric Seidel (no email) 2009-10-27 10:30:42 PDT 
Created attachment 41962 [details]
Patch v1
Comment 3 Adam Barth 2009-10-27 10:32:25 PDT 
Comment on attachment 41962 [details]
Patch v1

Ok.  Perl is dumb.
Comment 4 WebKit Commit Bot 2009-10-27 10:38:35 PDT 
Comment on attachment 41962 [details]
Patch v1

Clearing flags on attachment: 41962

Committed r50157: <http://trac.webkit.org/changeset/50157>
Comment 5 WebKit Commit Bot 2009-10-27 10:38:40 PDT 
All reviewed patches have been landed.  Closing bug.