The result of this test added in the patch solving the bug 30689 does not work:
--- layout-test-results/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll-expected.txt 2009-10-27 03:22:05.414649015 -0700
+++ layout-test-results/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll-actual.txt 2009-10-27 03:22:05.414649015 -0700
@@ -10,8 +10,8 @@
+Failure, actual: 82; expected: 93
+Failure, actual: 15; expected: 19
+Failure, actual: 53; expected: 64
Created attachment 84811 [details]
The test fails in chromium and qt as well.
Patch to make the test cross-platform.
Comment on attachment 84811 [details]
Ah, I run it in Mac and chromium-mac. I should run in chromium-linux. Seems that the test for elementFromPoint() is not correct in chromium-linux.
Created attachment 84827 [details]
Comment on attachment 84827 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=84827&action=review
I tested this change locally and the test is now passing on GTK+. Thanks for the cleanup!
> + var expectedOffset = 29;
Might want to leave a comment here explaining where 29 comes from.
> + function check(message, event)
I recommend naming this function something a bit more descriptive.
> + var range =document.caretRangeFromPoint(event.clientX, event.clientY);
Missing a space after the equal sign here.
Committed r80492: <http://trac.webkit.org/changeset/80492>