RESOLVED FIXED 30812
[Regression 50090] Windows and Qt fail new editing/style/remove-nested-inline-styles.html test 
https://bugs.webkit.org/show_bug.cgi?id=30812
Summary [Regression 50090] Windows and Qt fail new editing/style/remove-nested-inline...
Attachments
Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2009-10-27 11:32:03 PDT
This is due to the bug 30784. My patch for 30784 (which has been r- for various reasons) should also fix this bug.
Ryosuke Niwa
Comment 2 2009-10-27 11:38:11 PDT
To clarify, on very platform except Mac, executeToggleStyle will check if the entire selection has the specified style. But because of the bug 30784 (nested b'tag result in tri state of false), the selectionHasStyle returns false in Windows and Qt platforms.
Eric Seidel (no email)
Comment 3 2009-10-27 11:41:11 PDT
So what's your suggestion for how we should resolve this? We can't leave tests red on the bots. :( Do Windows/Qt need platform-specific results? Should the "failing" section of the test be split out into a mac-only test?
Ryosuke Niwa
Comment 4 2009-10-27 12:28:37 PDT
(In reply to comment #3) > So what's your suggestion for how we should resolve this? We can't leave tests > red on the bots. :( > > Do Windows/Qt need platform-specific results? Should the "failing" section of > the test be split out into a mac-only test? I have fixed my patch for the bug 30784. Could you take a look? This should fix Windows build unless I misunderstood the problem and I'm not reproducing the error properly. Around L166 of EditorCommand.cpp inside executeToggleStyle, there is a if-statement that changes behavior for Mac. I have confirmed that this bug is demonstrated when I forced to run the statement in else clause, and is fixed with my patch. I'd like to confirm this on Windows but unfortunately, I don't have access to Windows machine with WebKit check out.
Ryosuke Niwa
Comment 5 2009-10-28 10:33:23 PDT
This regression has been fixed in http://trac.webkit.org/changeset/50172.
Note You need to log in before you can comment on or make changes to this bug.