WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
30810
bugzilla-tool rollout should require a reason
https://bugs.webkit.org/show_bug.cgi?id=30810
Summary
bugzilla-tool rollout should require a reason
Eric Seidel (no email)
Reported
2009-10-27 02:11:11 PDT
bugzilla-tool rollout should prompt for "why?" It's useful to include "why" we are rolling out a change in the ChangeLog. bugzilla-tool rollout should prompt for such and include it in the ChangeLog.
Attachments
Patch
(9.75 KB, patch)
2010-01-04 21:20 PST
,
Eric Seidel (no email)
abarth
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2009-12-29 13:40:42 PST
@Adam: Shouldn't this be super-easy now with the "EditChangeLogStep" already built? And there is a "Show them a diff to confirm" step now too, no?
Eric Seidel (no email)
Comment 2
2010-01-04 21:16:29 PST
I'm just making a reason required. It's now a command line argument. I've also added a EditChangeLog and ConfirmDiff steps.
Eric Seidel (no email)
Comment 3
2010-01-04 21:20:22 PST
Created
attachment 45860
[details]
Patch
Adam Barth
Comment 4
2010-01-04 21:24:16 PST
Comment on
attachment 45860
[details]
Patch Okiedokes
Eric Seidel (no email)
Comment 5
2010-01-04 21:33:40 PST
Committed
r52785
: <
http://trac.webkit.org/changeset/52785
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug