Bug 30800 - Cache recently computed date data
Summary: Cache recently computed date data
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-26 17:38 PDT by Geoffrey Garen
Modified: 2009-10-27 15:21 PDT (History)
0 users

See Also:


Attachments
patch (23.91 KB, patch)
2009-10-26 17:39 PDT, Geoffrey Garen
darin: review-
Details | Formatted Diff | Diff
patch - now with 100% more new files! (27.14 KB, patch)
2009-10-27 12:07 PDT, Geoffrey Garen
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2009-10-26 17:38:43 PDT
Patch coming.
Comment 1 Geoffrey Garen 2009-10-26 17:39:13 PDT
Created attachment 41921 [details]
patch
Comment 2 mitz 2009-10-26 17:43:36 PDT
Comment on attachment 41921 [details]
patch

This patch is missing the new files (they’re also not listed in the change log).
Comment 3 Darin Adler 2009-10-26 17:47:30 PDT
Comment on attachment 41921 [details]
patch

> -        bool getGregorianDateTime(bool outputIsUTC, WTF::GregorianDateTime&) const;
> +        bool getGregorianDateTime(ExecState* exec, bool outputIsUTC, WTF::GregorianDateTime&) const;

No need for the argument name "exec" here.

You forgot to "svn add" the new files so I could not review them. review- because this is not a complete patch
Comment 4 Geoffrey Garen 2009-10-27 12:07:28 PDT
Created attachment 41973 [details]
patch - now with 100% more new files!
Comment 5 Geoffrey Garen 2009-10-27 15:21:16 PDT
http://trac.webkit.org/changeset/50174