Bug 30798 - REGRESSION (r48687): www.myuhc.com appears blank.
Summary: REGRESSION (r48687): www.myuhc.com appears blank.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P1 Normal
Assignee: Brady Eidson
URL: http://myuhc.com
Depends on:
Reported: 2009-10-26 16:53 PDT by Brady Eidson
Modified: 2009-10-26 17:20 PDT (History)
0 users

See Also:

Notify all descendants, not just child frames. (deleted)
2009-10-26 17:12 PDT, Brady Eidson
darin: review+
beidson: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2009-10-26 16:53:39 PDT
Pages with frames nested more than 1 level deep from the main frame that also have redirects at those deep frames were broken by r48687.

This is because child frames now care that *ALL* of their ancestors have finished loading, instead of just their direct parents.  But frames don't tell all of their descendants they finished, only their direct children.

The fix is to have frames tell all of their descendants when they finish loading.
Comment 1 Brady Eidson 2009-10-26 17:12:28 PDT
Created attachment 41916 [details]
Notify all descendants, not just child frames.
Comment 2 Darin Adler 2009-10-26 17:15:38 PDT
Comment on attachment 41916 [details]
Notify all descendants, not just child frames.

I would like the test better if it documented success better. The most helpful text in the test is in meta-redirect-to-notify-done.html and that text does not display. In the grandparent it would be good to say a word or two about what a successful result looks like.
Comment 3 Brady Eidson 2009-10-26 17:20:12 PDT
Committed r50116.