Bug 30794 - [V8] Tidy up the DOM Storage runtime flag stuff
Summary: [V8] Tidy up the DOM Storage runtime flag stuff
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Jeremy Orlow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-26 15:50 PDT by Jeremy Orlow
Modified: 2009-10-26 16:45 PDT (History)
2 users (show)

See Also:


Attachments
Patch v1 (5.32 KB, patch)
2009-10-26 15:52 PDT, Jeremy Orlow
dglazkov: review+
dglazkov: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2009-10-26 15:50:40 PDT
Clean up the DOM Storage runtime flag stuff to match the new way of doing things.
Comment 1 Jeremy Orlow 2009-10-26 15:52:48 PDT
Created attachment 41908 [details]
Patch v1
Comment 2 Dimitri Glazkov (Google) 2009-10-26 15:55:48 PDT
Comment on attachment 41908 [details]
Patch v1

r=me, except -- I don't know for sure, but I think all new code uses just camelCase for statics. Can you change that back?
Comment 3 Dumitru Daniliuc 2009-10-26 16:11:21 PDT
I've seen more static variables without s_, and Eric raised the same question when I uploaded a patch with s_ static variables. So I think we should get rid of the s_ prefix.

Also, I don't see why 'enabled' is better than 'isEnabled': ~15 'bool enabled' parameters in ~5 different .cpp files in all of WebCore can hardly be called a 'standard'. But I don't feel strongly about this.
Comment 4 Jeremy Orlow 2009-10-26 16:16:27 PDT
I switched back to isBlahBlahEnabled and isEnabled.  Didn't realize those were the more accepted conventions.  (Kind of wish that, whenever such decisions are made, that people would just change everything over right away....it's so hard knowing what's currently in favor!)
Comment 5 Jeremy Orlow 2009-10-26 16:45:18 PDT
Committed r50113: <http://trac.webkit.org/changeset/50113>