RESOLVED FIXED307928
Remove empty #if/#endif blocks regressed by recent protected*() cleanup 
https://bugs.webkit.org/show_bug.cgi?id=307928
Summary Remove empty #if/#endif blocks regressed by recent protected*() cleanup
David Kilzer (:ddkilzer)
Reported 2026-02-14 20:27:35 PST
Recent commits that removed protected*() getter functions left behind empty preprocessor conditional blocks that should be cleaned up. Empty blocks found: - Source/WebKit/UIProcess/WebPageProxyInternals.h: `ENABLE(WINDOW_PROXY_PROPERTY_ACCESS_NOTIFICATION)` - Source/WebKit/UIProcess/Network/NetworkProcessProxy.h: `ENABLE(LEGACY_CUSTOM_PROTOCOL_MANAGER)` - Source/WebKit/UIProcess/WebPageProxy.cpp: `PLATFORM(IOS_FAMILY) && ENABLE(DEVICE_ORIENTATION)` - Source/WebKit/UIProcess/WebPageProxy.h: `PLATFORM(IOS_FAMILY) && ENABLE(DEVICE_ORIENTATION)` These empty blocks were created when the last code between the preprocessor directives was removed but the directives themselves were left in place. Regression commits: - Bug 306206 (306184@main): WebPageProxy.cpp, WebPageProxy.h - Bug 306264 (306257@main): WebPageProxyInternals.h, NetworkProcessProxy.h
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2026-02-14 20:27:42 PST
<rdar://problem/170409330>
David Kilzer (:ddkilzer)
Comment 2 2026-02-14 20:35:10 PST
Pull request: https://github.com/WebKit/WebKit/pull/58742
EWS
Comment 3 2026-02-14 20:58:32 PST
Committed 307605@main (f5922987b579): <https://commits.webkit.org/307605@main> Reviewed commits have been landed. Closing PR #58742 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.