Need to do a renaming pass in InspectorTimelineAgent, InspectorFrontend, TimelineAgent.js to favor "record" over "item"
Created attachment 41899 [details] Renames everything.
Comment on attachment 41899 [details] Renames everything. Should RecordEntry be TimelineRecord? (Like TimelineRecordType.) RecordEntry just sounds funny.
(In reply to comment #2) > (From update of attachment 41899 [details]) > Should RecordEntry be TimelineRecord? (Like TimelineRecordType.) RecordEntry > just sounds funny. Probably, I used the convent of calling them Records inside of InspectorTimelineAgent and TimelineRecords elsewhere. New patch coming.
Created attachment 41907 [details] Renamed to TimelineRecordEntry
Comment on attachment 41907 [details] Renamed to TimelineRecordEntry Rejecting patch 41907 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11520 test cases. svg/css/getComputedStyle-basic.xhtml -> failed Exiting early after 1 failures. 9845 tests run. 320.40s total testing time 9844 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 6 test cases (<1%) had stderr output
Comment on attachment 41907 [details] Renamed to TimelineRecordEntry Flaky test?
Sorry. The bots are just way behind. bug 30098
Comment on attachment 41907 [details] Renamed to TimelineRecordEntry Clearing flags on attachment: 41907 Committed r50125: <http://trac.webkit.org/changeset/50125>
All reviewed patches have been landed. Closing bug.