Bug 30785 - Rename TimelineItems to TimelineRecords and update all references.
Summary: Rename TimelineItems to TimelineRecords and update all references.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-26 12:48 PDT by Kelly Norton
Modified: 2009-10-26 20:24 PDT (History)
4 users (show)

See Also:


Attachments
Renames everything. (36.57 KB, patch)
2009-10-26 14:29 PDT, Kelly Norton
no flags Details | Formatted Diff | Diff
Renamed to TimelineRecordEntry (36.61 KB, patch)
2009-10-26 15:38 PDT, Kelly Norton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kelly Norton 2009-10-26 12:48:04 PDT
Need to do a renaming pass in InspectorTimelineAgent, InspectorFrontend, TimelineAgent.js to favor "record" over "item"
Comment 1 Kelly Norton 2009-10-26 14:29:55 PDT
Created attachment 41899 [details]
Renames everything.
Comment 2 Timothy Hatcher 2009-10-26 14:34:25 PDT
Comment on attachment 41899 [details]
Renames everything.

Should RecordEntry be TimelineRecord? (Like TimelineRecordType.) RecordEntry just sounds funny.
Comment 3 Kelly Norton 2009-10-26 14:37:37 PDT
(In reply to comment #2)
> (From update of attachment 41899 [details])
> Should RecordEntry be TimelineRecord? (Like TimelineRecordType.) RecordEntry
> just sounds funny.

Probably, I used the convent of calling them Records inside of InspectorTimelineAgent and TimelineRecords elsewhere. New patch coming.
Comment 4 Kelly Norton 2009-10-26 15:38:56 PDT
Created attachment 41907 [details]
Renamed to TimelineRecordEntry
Comment 5 WebKit Commit Bot 2009-10-26 16:12:06 PDT
Comment on attachment 41907 [details]
Renamed to TimelineRecordEntry

Rejecting patch 41907 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11520 test cases.
svg/css/getComputedStyle-basic.xhtml -> failed

Exiting early after 1 failures. 9845 tests run.
320.40s total testing time

9844 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
6 test cases (<1%) had stderr output
Comment 6 Pavel Feldman 2009-10-26 16:15:47 PDT
Comment on attachment 41907 [details]
Renamed to TimelineRecordEntry

Flaky test?
Comment 7 Eric Seidel (no email) 2009-10-26 16:25:04 PDT
Sorry.  The bots are just way behind.  bug 30098
Comment 8 WebKit Commit Bot 2009-10-26 20:24:13 PDT
Comment on attachment 41907 [details]
Renamed to TimelineRecordEntry

Clearing flags on attachment: 41907

Committed r50125: <http://trac.webkit.org/changeset/50125>
Comment 9 WebKit Commit Bot 2009-10-26 20:24:17 PDT
All reviewed patches have been landed.  Closing bug.