RESOLVED FIXED307823
Cleanup display property style representation
https://bugs.webkit.org/show_bug.cgi?id=307823
Summary Cleanup display property style representation
Sam Weinig
Reported 2026-02-13 10:32:00 PST
Cleanup display property style representation. - Moved enum from RenderStyleConstants.h to StyleDisplay.h and into the Style namespace. - Moved predicates from RenderStyle to StyleDisplay.h and into the Style namespace. - Renames enum values to the non-shortened names to make outside/inside structure more clear. - Renames `equivalentBlockDisplay()`/`equivalentInlineDisplay()` to `blockify()`/`inlinify()`, matching their spec names and related predicates (like the existing `shouldInlinifyForRuby()`). - Renames `setEffectiveDisplay` to `setDisplayMaintainingOriginalDisplay` to make it clear what it is doing. Also removes the `effectiveDisplay` terminology entirely, renaming the member variable from `effectiveDisplay` to `display`. - Add CSSValueConversion implementation. This will be needed for properly implementing `block ruby` serialization in a forthcoming change. - Add ValueRepresentation implementation. This allows us to remove the logging and toCSSValueID implementations, and will also be needed for properly implementing `block ruby` serialization in a forthcoming change. - Add Blending implementation to remove another use of custom animation wrappers/functions.
Attachments
Sam Weinig
Comment 1 2026-02-13 11:37:42 PST
EWS
Comment 2 2026-02-14 11:20:40 PST
Committed 307580@main (70c23162b81c): <https://commits.webkit.org/307580@main> Reviewed commits have been landed. Closing PR #58649 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2026-02-14 11:21:14 PST
Note You need to log in before you can comment on or make changes to this bug.