Bug 30782 - The thunkReturnAddress should be on JITStackFrame on ARM JIT
Summary: The thunkReturnAddress should be on JITStackFrame on ARM JIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-26 11:50 PDT by Gabor Loki
Modified: 2009-10-26 15:49 PDT (History)
4 users (show)

See Also:


Attachments
The thunkReturnAddress is on JITStackFrame on ARM JIT as well (10.69 KB, patch)
2009-10-26 11:54 PDT, Gabor Loki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Loki 2009-10-26 11:50:21 PDT
Currently the thunkReturnAddress is stored on the top of the stack on ARM JIT. This scenario is similar to how x86 handles the return address. It works, but for further compatibility it would be nice if the return address is stored in JITStackFrame structure. This change is required to have a JSValue32_64 support for ARM JIT. In additional, it helps the Symbian assembler to identify that there is no stack alignment problem.
Comment 1 Gabor Loki 2009-10-26 11:54:05 PDT
Created attachment 41879 [details]
The thunkReturnAddress is on JITStackFrame on ARM JIT as well

The proposed patch works similar to ARMv7 solution.
Comment 2 Gabor Loki 2009-10-26 12:08:47 PDT
I've removed the hard block flag from bug 30552. We should manage the changes separately.
Comment 3 Geoffrey Garen 2009-10-26 12:30:44 PDT
Does this patch maintain the proper stack alignment?
Comment 4 Gabor Loki 2009-10-26 12:40:00 PDT
> Does this patch maintain the proper stack alignment?

Yes, it does. This solution is similar to ARMv7.
Comment 5 WebKit Commit Bot 2009-10-26 15:49:35 PDT
Comment on attachment 41879 [details]
The thunkReturnAddress is on JITStackFrame on ARM JIT as well

Clearing flags on attachment: 41879

Committed r50109: <http://trac.webkit.org/changeset/50109>
Comment 6 WebKit Commit Bot 2009-10-26 15:49:39 PDT
All reviewed patches have been landed.  Closing bug.