RESOLVED FIXED 30782
The thunkReturnAddress should be on JITStackFrame on ARM JIT 
https://bugs.webkit.org/show_bug.cgi?id=30782
Summary The thunkReturnAddress should be on JITStackFrame on ARM JIT
Gabor Loki
Reported 2009-10-26 11:50:21 PDT
Currently the thunkReturnAddress is stored on the top of the stack on ARM JIT. This scenario is similar to how x86 handles the return address. It works, but for further compatibility it would be nice if the return address is stored in JITStackFrame structure. This change is required to have a JSValue32_64 support for ARM JIT. In additional, it helps the Symbian assembler to identify that there is no stack alignment problem.
Attachments
The thunkReturnAddress is on JITStackFrame on ARM JIT as well (10.69 KB, patch)
2009-10-26 11:54 PDT, Gabor Loki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gabor Loki
Comment 1 2009-10-26 11:54:05 PDT
Created attachment 41879 [details] The thunkReturnAddress is on JITStackFrame on ARM JIT as well The proposed patch works similar to ARMv7 solution.
Gabor Loki
Comment 2 2009-10-26 12:08:47 PDT
I've removed the hard block flag from bug 30552. We should manage the changes separately.
Geoffrey Garen
Comment 3 2009-10-26 12:30:44 PDT
Does this patch maintain the proper stack alignment?
Gabor Loki
Comment 4 2009-10-26 12:40:00 PDT
> Does this patch maintain the proper stack alignment? Yes, it does. This solution is similar to ARMv7.
WebKit Commit Bot
Comment 5 2009-10-26 15:49:35 PDT
Comment on attachment 41879 [details] The thunkReturnAddress is on JITStackFrame on ARM JIT as well Clearing flags on attachment: 41879 Committed r50109: <http://trac.webkit.org/changeset/50109>
WebKit Commit Bot
Comment 6 2009-10-26 15:49:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.