Bug 30779 - [Qt] Make QWebPagePrivate's (QWidget) view to be a QWeakPointer
Summary: [Qt] Make QWebPagePrivate's (QWidget) view to be a QWeakPointer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-10-26 09:39 PDT by Antonio Gomes
Modified: 2009-10-28 03:25 PDT (History)
4 users (show)

See Also:


Attachments
(committed in r50142) patch 0.1 (10.20 KB, patch)
2009-10-26 09:40 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff
(committed in r50209) patch 0.2 (1.71 KB, patch)
2009-10-27 14:12 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2009-10-26 09:39:01 PDT
No one is deleting it explicitly, so it can lead to dangling pointers. Making it a qweakpointer would get us safier.

patch coming ...
Comment 1 Antonio Gomes 2009-10-26 09:40:09 PDT
Created attachment 41872 [details]
(committed in r50142) patch 0.1
Comment 2 Antonio Gomes 2009-10-27 06:46:58 PDT
commit in r50142

thx for reviewing
Comment 3 Antonio Gomes 2009-10-27 14:12:04 PDT
Created attachment 41984 [details]
(committed in r50209) patch 0.2

Patch updated what documentation says: for qweakpointer's tracking qobjects use data() not toStringRef().data()

http://doc.trolltech.com/4.6-snapshot/qweakpointer.html#tracking-qobject

it fixes current Qt-DRT crash
Comment 4 Antonio Gomes 2009-10-27 14:12:39 PDT
reopening to track the pending commit
Comment 5 Holger Freyther 2009-10-28 00:41:46 PDT
Hmm... bad inconsistency and the "other context" is pretty vague too.. I would r=+ if you agree to do a spelling fix before landing the commit.
Comment 6 Holger Freyther 2009-10-28 00:46:20 PDT
okay and the problem toStringRef it must be toStrongRef
Comment 7 Antonio Gomes 2009-10-28 03:24:58 PDT
patch 2 landed in r50209

thx zecke