Bug 30751 – HTMLOptionsCollection should not inherit from HTMLCollection (according to HTML5)

• Status: RESOLVED
• Resolution: INVALID
• Component: DOM

[Sam Weinig]

HTMLOptionsCollection should not inherit from HTMLCollection (according to HTML5).  Right now, only our JS bindings have this issue.

[Sam Weinig]

Created attachment 41800 [details]
patch

Comment on attachment 41800 [details]
patch

r=me assuming you add the new .h file to other project files and address the comments from IRC.

[Sam Weinig]

Fixed in r50037.

[Brian Weinstein]

This broke the Windows build, so rolled out in r50040.

Build error: http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/6258/steps/compile-webkit/logs/stdio

[Joseph Pecoraro]

Hmm, this bug was made 10/24 but it must have been a few hours later that the following was committed to HTML5

  Make collections inherit from HTMLCollection
  Fixing http://www.w3.org/Bugs/Public/show_bug.cgi?id=8035

Commit Diff:
http://html5.org/tools/web-apps-tracker?from=4322&to=4323

> -  <pre class="idl">interface <dfn>HTMLOptionsCollection</dfn> {
-           attribute unsigned long <span title="dom-HTMLOptionsCollection-length">length</span>;
> +  <pre class="idl">interface <dfn>HTMLOptionsCollection</dfn> : <span>HTMLCollection</span> {

[Sam Weinig]

(In reply to comment #5)
> Hmm, this bug was made 10/24 but it must have been a few hours later that the
> following was committed to HTML5
> 
>   Make collections inherit from HTMLCollection
>   Fixing http://www.w3.org/Bugs/Public/show_bug.cgi?id=8035
> 
> Commit Diff:
> http://html5.org/tools/web-apps-tracker?from=4322&to=4323
> 
> > -  <pre class="idl">interface <dfn>HTMLOptionsCollection</dfn> {
> -           attribute unsigned long <span
> title="dom-HTMLOptionsCollection-length">length</span>;
> > +  <pre class="idl">interface <dfn>HTMLOptionsCollection</dfn> : <span>HTMLCollection</span> {

Wow.  That is quite upsetting.  Fun times.

[Eric Seidel (no email)]

Comment on attachment 41800 [details]
patch

Clearing mitz's r+ on this patch since it was rolled out.  (This was it's not in the to-be-committed list).

[Sam Weinig]

I rolled out this change in r50087.

[Alexey Proskuryakov]

*** Bug 32997 has been marked as a duplicate of this bug. ***