Bug 30750 - Make .rc files compile on Windows without depending on MFC headers
Summary: Make .rc files compile on Windows without depending on MFC headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Laszlo Gombos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-24 14:48 PDT by Laszlo Gombos
Modified: 2009-10-26 19:34 PDT (History)
4 users (show)

See Also:


Attachments
proposed patch (4.73 KB, patch)
2009-10-24 14:55 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-10-24 14:48:18 PDT
It seems to me that that a few Safari win components are unnecessary depend on MFC. The two header files that are used from MFC as a dependency (winres.h and afxres.h) can be easily eliminated by including winresrc.h and windows.h instead. winres.h is nothing more than the MFC wrapper around winresrc.h.

The benefit of these changes would be that for those using VC Express installing "Windows Server 2003 R2 Platform SDK" becomes unnecessary (see http://webkit.org/building/tools.html).
Comment 1 Laszlo Gombos 2009-10-24 14:55:01 PDT
Created attachment 41797 [details]
proposed patch
Comment 2 Laszlo Gombos 2009-10-24 19:19:07 PDT
Just another thought why this could be useful - as far as I know none of the other WebKit win ports (e.g Qt, wx) depends directly on MFC.
Comment 3 Darin Adler 2009-10-25 17:25:52 PDT
Comment on attachment 41797 [details]
proposed patch

If the comments in the change log explained why these are good changes, this patch would be much better! It could simply say something like "Use winresrc.h because it exists even when MFC is not installed, and is all that's needed here." And the equivalent elsewhere.

Or the bug title could be more specific: "Make .rc files compile on Windows without depending on MFC headers." Then you might be OK without further comments.

Either of these changes would remove the mysterious "improvements" aspect of this and make this small simple patch much better!

r=me, as is. Next time, please be clearer in the change log or the bug title or both.
Comment 4 Laszlo Gombos 2009-10-26 12:07:23 PDT
Will land myself fixing the ChangeLog as suggested by Darin.
Comment 5 Laszlo Gombos 2009-10-26 19:33:54 PDT
Landed as http://trac.webkit.org/changeset/50120. Thanks for the review, Darin !