Bug 30750 – Make .rc files compile on Windows without depending on MFC headers

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Laszlo Gombos]

It seems to me that that a few Safari win components are unnecessary depend on MFC. The two header files that are used from MFC as a dependency (winres.h and afxres.h) can be easily eliminated by including winresrc.h and windows.h instead. winres.h is nothing more than the MFC wrapper around winresrc.h.

The benefit of these changes would be that for those using VC Express installing "Windows Server 2003 R2 Platform SDK" becomes unnecessary (see http://webkit.org/building/tools.html).

[Laszlo Gombos]

Created attachment 41797 [details]
proposed patch

[Laszlo Gombos]

Just another thought why this could be useful - as far as I know none of the other WebKit win ports (e.g Qt, wx) depends directly on MFC.

[Darin Adler]

Comment on attachment 41797 [details]
proposed patch

If the comments in the change log explained why these are good changes, this patch would be much better! It could simply say something like "Use winresrc.h because it exists even when MFC is not installed, and is all that's needed here." And the equivalent elsewhere.

Or the bug title could be more specific: "Make .rc files compile on Windows without depending on MFC headers." Then you might be OK without further comments.

Either of these changes would remove the mysterious "improvements" aspect of this and make this small simple patch much better!

r=me, as is. Next time, please be clearer in the change log or the bug title or both.

[Laszlo Gombos]

Will land myself fixing the ChangeLog as suggested by Darin.

[Laszlo Gombos]

Landed as http://trac.webkit.org/changeset/50120. Thanks for the review, Darin !