Bug 30748 – Missing images at 350.org due to wrong URLs

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

At <http://www.350.org/>, all images in the slideshow are broken. The Web Inspector shows that their src attribute values are of the form <http://www.350.org/http://350.cdn.advomatic.com/sites/all/files/slides/georgetown_guyana_school.jpg>, whereas the correct URL for the image is of the form <http://350.cdn.advomatic.com/sites/all/files/slides/georgetown_guyana_school.jpg>. The images are displayed correctly in Firefox (and Firebug shows them to have the correct src).

Created attachment 41788 [details]
Reduction

Both Firefox and Opera print 'true' for the reduction.

Created attachment 41793 [details]
Use deprecatedParseURL() in getURLAttribute

Created attachment 41795 [details]
Use deprecatedParseURL() in getURLAttribute()

Fixed in <http://trac.webkit.org/changeset/50029>.

[Darin Adler]

If stripping whitespace is what's needed, then I wish we would do just that rather than deprecatedParseURL, but I suppose it's best to be consistent :-(

(In reply to comment #6)
> If stripping whitespace is what's needed, then I wish we would do just that
> rather than deprecatedParseURL, but I suppose it's best to be consistent :-(

I didn’t know exactly what king of cleanup was needed, so I just went with what the loader and the Objective-C bindings were already doing. deprecatedParseURL() is almost certainly wrong, and I would have added a FIXME in all three call sites if it weren’t already named “deprecated”.