Bug 30748 - Missing images at 350.org due to wrong URLs
Summary: Missing images at 350.org due to wrong URLs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: mitz
URL: http://www.350.org/
Keywords: HasReduction
Depends on:
Blocks:
 
Reported: 2009-10-24 11:58 PDT by mitz
Modified: 2009-10-25 17:31 PDT (History)
1 user (show)

See Also:

Attachments
Reduction (164 bytes, text/html)
2009-10-24 12:10 PDT, mitz 		no flags Details
Use deprecatedParseURL() in getURLAttribute (4.37 KB, patch)
2009-10-24 13:28 PDT, mitz 		no flags Details | Formatted Diff | Diff
Use deprecatedParseURL() in getURLAttribute() (5.50 KB, patch)
2009-10-24 13:41 PDT, mitz 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2009-10-24 11:58:06 PDT 
At <http://www.350.org/>, all images in the slideshow are broken. The Web Inspector shows that their src attribute values are of the form <http://www.350.org/http://350.cdn.advomatic.com/sites/all/files/slides/georgetown_guyana_school.jpg>, whereas the correct URL for the image is of the form <http://350.cdn.advomatic.com/sites/all/files/slides/georgetown_guyana_school.jpg>. The images are displayed correctly in Firefox (and Firebug shows them to have the correct src).
Comment 1 mitz 2009-10-24 12:10:01 PDT 
Created attachment 41788 [details]
Reduction
Comment 2 mitz 2009-10-24 12:16:57 PDT 
Both Firefox and Opera print 'true' for the reduction.
Comment 3 mitz 2009-10-24 13:28:22 PDT 
Created attachment 41793 [details]
Use deprecatedParseURL() in getURLAttribute
Comment 4 mitz 2009-10-24 13:41:14 PDT 
Created attachment 41795 [details]
Use deprecatedParseURL() in getURLAttribute()
Comment 5 mitz 2009-10-24 15:16:56 PDT 
Fixed in <http://trac.webkit.org/changeset/50029>.
Comment 6 Darin Adler 2009-10-25 17:21:49 PDT 
If stripping whitespace is what's needed, then I wish we would do just that rather than deprecatedParseURL, but I suppose it's best to be consistent :-(
Comment 7 mitz 2009-10-25 17:31:28 PDT 
(In reply to comment #6)
> If stripping whitespace is what's needed, then I wish we would do just that
> rather than deprecatedParseURL, but I suppose it's best to be consistent :-(

I didn’t know exactly what king of cleanup was needed, so I just went with what the loader and the Objective-C bindings were already doing. deprecatedParseURL() is almost certainly wrong, and I would have added a FIXME in all three call sites if it weren’t already named “deprecated”.