WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
30745
[v8] implement ReturnsNew IDL hint for V8 code generator
https://bugs.webkit.org/show_bug.cgi?id=30745
Summary
[v8] implement ReturnsNew IDL hint for V8 code generator
anton muhin
Reported
2009-10-24 11:52:09 PDT
In IDL some methods has ReturnsNew tag which guarantees that results of such methods are fresh objects. It allows to skip checks for presence of the wrapper for the object.
Attachments
First take
(2.16 KB, patch)
2009-10-24 11:55 PDT
,
anton muhin
abarth
: review+
abarth
: commit-queue-
Details
Formatted Diff
Diff
"No new tests" line removed
(2.12 KB, patch)
2009-10-24 15:04 PDT
,
anton muhin
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
anton muhin
Comment 1
2009-10-24 11:55:32 PDT
Created
attachment 41786
[details]
First take
Adam Barth
Comment 2
2009-10-24 12:00:53 PDT
Comment on
attachment 41786
[details]
First take This looks fine. + No new tests. (OOPS!) This line will prevent the commit-queue from landing the patch, however.
anton muhin
Comment 3
2009-10-24 15:04:30 PDT
Created
attachment 41798
[details]
"No new tests" line removed
anton muhin
Comment 4
2009-10-24 15:05:42 PDT
(In reply to
comment #2
)
> (From update of
attachment 41786
[details]
) > This looks fine. > > + No new tests. (OOPS!) > > This line will prevent the commit-queue from landing the patch, however.
Thanks a lot for review, Adam. "No new tests" line removed in the new patch.
WebKit Commit Bot
Comment 5
2009-10-24 15:40:25 PDT
Comment on
attachment 41798
[details]
"No new tests" line removed Clearing flags on attachment: 41798 Committed
r50030
: <
http://trac.webkit.org/changeset/50030
>
WebKit Commit Bot
Comment 6
2009-10-24 15:40:28 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug