Bug 30745 - [v8] implement ReturnsNew IDL hint for V8 code generator
Summary: [v8] implement ReturnsNew IDL hint for V8 code generator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-24 11:52 PDT by anton muhin
Modified: 2009-10-24 15:40 PDT (History)
1 user (show)

See Also:


Attachments
First take (2.16 KB, patch)
2009-10-24 11:55 PDT, anton muhin
abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff
"No new tests" line removed (2.12 KB, patch)
2009-10-24 15:04 PDT, anton muhin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description anton muhin 2009-10-24 11:52:09 PDT
In IDL some methods has ReturnsNew tag which guarantees that results of such methods are fresh objects.  It allows to skip checks for presence of the wrapper for the object.
Comment 1 anton muhin 2009-10-24 11:55:32 PDT
Created attachment 41786 [details]
First take
Comment 2 Adam Barth 2009-10-24 12:00:53 PDT
Comment on attachment 41786 [details]
First take

This looks fine.

+        No new tests. (OOPS!)

This line will prevent the commit-queue from landing the patch, however.
Comment 3 anton muhin 2009-10-24 15:04:30 PDT
Created attachment 41798 [details]
"No new tests" line removed
Comment 4 anton muhin 2009-10-24 15:05:42 PDT
(In reply to comment #2)
> (From update of attachment 41786 [details])
> This looks fine.
> 
> +        No new tests. (OOPS!)
> 
> This line will prevent the commit-queue from landing the patch, however.

Thanks a lot for review, Adam.  "No new tests" line removed in the new patch.
Comment 5 WebKit Commit Bot 2009-10-24 15:40:25 PDT
Comment on attachment 41798 [details]
"No new tests" line removed

Clearing flags on attachment: 41798

Committed r50030: <http://trac.webkit.org/changeset/50030>
Comment 6 WebKit Commit Bot 2009-10-24 15:40:28 PDT
All reviewed patches have been landed.  Closing bug.