Bug 30743 - Web Inspector: REGRESSION: Can't click on Resources to view them
Summary: Web Inspector: REGRESSION: Can't click on Resources to view them
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: Timothy Hatcher
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2009-10-24 10:58 PDT by Timothy Hatcher
Modified: 2009-10-24 20:01 PDT (History)
6 users (show)

See Also:

Attachments
Proposed Patch (1.81 KB, patch)
2009-10-24 13:34 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Proposed Patch (1.83 KB, patch)
2009-10-24 13:52 PDT, Timothy Hatcher 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2009-10-24 10:58:29 PDT 
You can no longer click on a Resource to view it.
Comment 1 Timothy Hatcher 2009-10-24 13:17:49 PDT 
This was caused by the Resource scope bar change. I have a fix I am working on.
Comment 2 Brian Weinstein 2009-10-24 13:21:06 PDT 
Will the fix for https://bugs.webkit.org/show_bug.cgi?id=30744 fix this? Or what did changing the scope bar do to break it? All that should do is change the css, nothing to do with clinking resources.
Comment 3 Timothy Hatcher 2009-10-24 13:22:19 PDT 
You removed WebInspector.panels.resources._filterCategory, and it is used to determine selectability.
Comment 4 Brian Weinstein 2009-10-24 13:23:37 PDT 
Oh, hm, that is weird. Why does it need _filterCategory for selectability? Sorry, I didn't think that would be an issue so I didn't check it.
Comment 5 Timothy Hatcher 2009-10-24 13:34:46 PDT 
Created attachment 41794 [details]
Proposed Patch
Comment 6 Timothy Hatcher 2009-10-24 13:35:54 PDT 
Since the filter just hides the items in the tree, they are still there. So selectable is called when arrowing through the list. Otherwise you would arrow to invisible resources.
Comment 7 Brian Weinstein 2009-10-24 13:37:24 PDT 
(In reply to comment #5)
> Created an attachment (id=41794) [details]
> Proposed Patch

Does the category name need to be in lower case? Are CSS classes case sensitive? Otherwise, looks good here but I can't review yet.
Comment 8 Timothy Hatcher 2009-10-24 13:52:03 PDT 
Created attachment 41796 [details]
Proposed Patch
Comment 9 Brian Weinstein 2009-10-24 13:55:44 PDT 
(In reply to comment #8)
> Created an attachment (id=41796) [details]
> Proposed Patch

Looks good, hopefully pfeldman or someone can come along and r+ it.
Comment 10 Timothy Hatcher 2009-10-24 20:01:59 PDT 
Committed r50035: <http://trac.webkit.org/changeset/50035>