WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
30742
Web Inspector: REGRESSION: Can't resize the Element's sidebar
https://bugs.webkit.org/show_bug.cgi?id=30742
Summary
Web Inspector: REGRESSION: Can't resize the Element's sidebar
Timothy Hatcher
Reported
2009-10-24 09:47:18 PDT
The Element's sidebar can't be resized anymore. It seems the resize div is floating in the middle of the elements tree somewhere. Maybe this was caused by the sidebar migration to Panel?
Attachments
Proposed Patch
(14.50 KB, patch)
2009-10-24 11:08 PDT
,
Timothy Hatcher
pfeldman
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Timothy Hatcher
Comment 1
2009-10-24 11:08:21 PDT
Created
attachment 41784
[details]
Proposed Patch
Joseph Pecoraro
Comment 2
2009-10-24 11:45:55 PDT
Hehe, the patch itself looks good to me. The only thing that caught my eye was something that wasn't changed, but showed up in the context:
> + updateMainViewWidth: function(width) > { > // Should be implemented by ancestors. > }
"ancestors" means ↑ (up). Really this should be the children (sub "classes") that implement it.
Pavel Feldman
Comment 3
2009-10-24 15:54:16 PDT
Comment on
attachment 41784
[details]
Proposed Patch Nice. I have nearly identical patch locally.
Pavel Feldman
Comment 4
2009-10-24 16:06:16 PDT
> "ancestors" means ↑ (up). Really this should be the children (sub "classes")
Oops. Should be subclasses.
Timothy Hatcher
Comment 5
2009-10-24 20:01:30 PDT
Committed
r50033
: <
http://trac.webkit.org/changeset/50033
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug