Bug 30735 – Web Inspector: hovering in the DOM tree it is very hard to double-click to edit

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Timothy Hatcher]

When hovering in the DOM tree it is very hard to double-click to edit now. The other day I was editing the Inspector with the Inspector to quickly test things for the Timeline mock-up. And I was very frustrated when I went to double-click on an attribute or text node that it would shift under my and I might miss it.

I think we need to rethink the hover to add a new attribute changes. I feel this was better when it didn't shift so much, but since it changed to: ?="" it is more likely going to shift and rewrap.

Options I see are:

- Some control show up on hover that does not affect layout. THe control could have other things like "New Child", etc in there.
- Move the controls to the right end of the row, or the left before the node.

(There is also a bug when the hover causes the text to wrap to a new line. THer selection highlight does not grow, so you don't see the white text on the new line. updateSelection() needs called.)

[Pavel Feldman]

(In reply to comment #0)
> When hovering in the DOM tree it is very hard to double-click to edit now. The
> other day I was editing the Inspector with the Inspector to quickly test things
> for the Timeline mock-up. And I was very frustrated when I went to double-click
> on an attribute or text node that it would shift under my and I might miss it.
> 
> I think we need to rethink the hover to add a new attribute changes. I feel
> this was better when it didn't shift so much, but since it changed to: ?="" it
> is more likely going to shift and rewrap.
> 

Actually, now that it has a timeout you have at least some chance of hitting what you want.

> Options I see are:
> 
> - Some control show up on hover that does not affect layout. THe control could
> have other things like "New Child", etc in there.
> - Move the controls to the right end of the row, or the left before the node.
> 
> (There is also a bug when the hover causes the text to wrap to a new line. THer
> selection highlight does not grow, so you don't see the white text on the new
> line. updateSelection() needs called.)

I don't think this operation should pop up on hover at all - it is not that important. I was thinking about a small "New" popup menu when user clicks "+" or "Insert" or win? Cmd+N would be too much I guess.

[Timothy Hatcher]

I think the timeout makes it tricky. Since It is fine for a bit, then by the time I double-click it changes.

Not having it on hover would be fine too, if we find a discoverable way to do it.

[Timothy Hatcher]

Created attachment 41783 [details]
Proposed Patch

[Timothy Hatcher]

Committed r50032: <http://trac.webkit.org/changeset/50032>