Bug 30730 - [Qt] Enable YARR when YARR_JIT is enabled
Summary: [Qt] Enable YARR when YARR_JIT is enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-10-23 15:30 PDT by Afonso Costa
Modified: 2009-10-28 14:44 PDT (History)
4 users (show)

See Also:


Attachments
Proposed patch (524 bytes, patch)
2009-10-23 15:30 PDT, Afonso Costa
no flags Details | Formatted Diff | Diff
Proposed patch - v2 (1.80 KB, patch)
2009-10-26 09:15 PDT, Afonso Costa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Afonso Costa 2009-10-23 15:30:26 PDT
Created attachment 41752 [details]
Proposed patch

When enabling or disabling JIT using JAVASCRIPTCORE_JIT, the ENABLE_YARR should be toggled also.
Comment 1 Gabor Loki 2009-10-26 07:29:53 PDT
> Created an attachment (id=41752) [details]

Please, add your ChangeLog entry as well.
See at http://webkit.org/coding/contributing.html .
Comment 2 Afonso Costa 2009-10-26 09:15:29 PDT
Created attachment 41870 [details]
Proposed patch - v2

Added changelog
Comment 3 Tor Arne Vestbø 2009-10-27 03:40:59 PDT
Thanks for your bug report.

In the future, please follow the QtWebKit bug reporting guidelines:

http://trac.webkit.org/wiki/QtWebKitContrib#ReportingBugs

In particular:

    - All bugs related to the Qt port of WebKit should have the keyword 'Qt'
    - The 'WebKit Qt' component should only be used for API layer bugs

You can use the following URL as a template:

    http://tinyurl.com/NewQtWebKitBug
Comment 4 Oliver Hunt 2009-10-28 12:57:21 PDT
Comment on attachment 41870 [details]
Proposed patch - v2

r=me
Comment 5 WebKit Commit Bot 2009-10-28 14:44:16 PDT
Comment on attachment 41870 [details]
Proposed patch - v2

Clearing flags on attachment: 41870

Committed r50239: <http://trac.webkit.org/changeset/50239>
Comment 6 WebKit Commit Bot 2009-10-28 14:44:20 PDT
All reviewed patches have been landed.  Closing bug.