MSAA clients expect that the name of image elements should include the alt attribute text. <rdar://problem/7328291>
Created attachment 41747 [details] patch
Comment on attachment 41747 [details] patch r=me
Comment on attachment 41747 [details] patch Rejecting patch 41747 from review queue. alice.liu@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.
i refrained from objecting to the original authoring of the commit script, and my objection would have been that i think it was populated in a questionable way. I didn't understand why it just didn't include every reviewer and committer from the get-go. We definitely have lists of who is and isn't allowed, and i don't understand why this script wasn't just populated correctly from its inception.
Looks like Alice was never added to committers.py for some reason. Since she's clearly a reviewer, I've taken the liberty of updating committers.py to include her. Our python scripts (including the commit-bot) will now correctly recognize her as a reviewer! http://trac.webkit.org/changeset/50003
(In reply to comment #4) > i refrained from objecting to the original authoring of the commit script, and > my objection would have been that i think it was populated in a questionable > way. I didn't understand why it just didn't include every reviewer and > committer from the get-go. We definitely have lists of who is and isn't > allowed, and i don't understand why this script wasn't just populated correctly > from its inception. Geez. Clearly this was mild human error. No need to get all excited! If you have objections to the commit-queue, I'd love to hear them. Ideally via email or bugs. I'm sorry your first experience with the commit-queue was not a positive one. :( Hopefully all will be better now!
the "some reason" is because the script included some unexplained subset of reviewers and committers in the first place, and then required every single person to add themselves. true efficiency.
Again, I'm sorry I missed you in my initial pass. You should feel free to edit committers.py to include anyone else who is missing. I'm not sure which lists of committers to which you refer. http://lists.webkit.org/mailman/roster.cgi/webkit-reviewers is the only one I know of. At one point I went through and tried to add everyone, obviously I missed you (and possibly others). But since the file is in the public repository you should feel free to edit it to you hearts content! :)
I think here we should've just ignored the commit-queue since its not relevant in this situation.
my point was missed(In reply to comment #8) > Again, I'm sorry I missed you in my initial pass. You should feel free to edit > committers.py to include anyone else who is missing. > But since the file is > in the public repository you should feel free to edit it to you hearts content! > :) you're completely missing my point. :)
Committed in r50004.