Bug 30720 - Web Inspector: pull basic sidebar implementation into the Panel.
Summary: Web Inspector: pull basic sidebar implementation into the Panel.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-23 11:12 PDT by Pavel Feldman
Modified: 2009-10-23 13:48 PDT (History)
1 user (show)

See Also:


Attachments
patch (10.73 KB, patch)
2009-10-23 11:13 PDT, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-10-23 11:12:30 PDT
Currently there is a bunch of copypaste in Profiles and Storage. There is almost the same piece in resources, but it scrolls differently...
Comment 1 Pavel Feldman 2009-10-23 11:13:35 PDT
Created attachment 41735 [details]
patch
Comment 2 Timothy Hatcher 2009-10-23 11:21:10 PDT
Comment on attachment 41735 [details]
patch

Nice!

Maybe setMainViewWidth is a better name than setCenterViewWidth?
Comment 3 Pavel Feldman 2009-10-23 13:48:23 PDT
Landing with comments addressed

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/Panel.js
	M	WebCore/inspector/front-end/ProfilesPanel.js
	M	WebCore/inspector/front-end/StoragePanel.js
Committed r49997