Bug 30719 - Fix the Chromium build after IsloatedWorld change (r49963)
Summary: Fix the Chromium build after IsloatedWorld change (r49963)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-23 10:57 PDT by Tony Chang
Modified: 2009-10-23 13:16 PDT (History)
1 user (show)

See Also:


Attachments
Patch v1 (5.26 KB, patch)
2009-10-23 11:02 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Patch v1 (8.64 KB, patch)
2009-10-23 11:11 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
v2 (8.62 KB, patch)
2009-10-23 11:31 PDT, Tony Chang
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2009-10-23 10:57:36 PDT
see summary
Comment 1 Tony Chang 2009-10-23 11:02:19 PDT
Created attachment 41732 [details]
Patch v1
Comment 2 Tony Chang 2009-10-23 11:02:53 PDT
Comment on attachment 41732 [details]
Patch v1

need changelog
Comment 3 Tony Chang 2009-10-23 11:11:27 PDT
Created attachment 41734 [details]
Patch v1
Comment 4 Tony Chang 2009-10-23 11:12:42 PDT
(In reply to comment #3)
> Created an attachment (id=41734) [details]
> Patch v1

I haven't tested the compile for webkit mac, let me do that before landing this.
Comment 5 David Levin 2009-10-23 11:25:46 PDT
Comment on attachment 41734 [details]
Patch v1

> diff --git a/WebCore/bindings/v8/ScriptController.cpp b/WebCore/bindings/v8/ScriptController.cpp

> +// FIXME

Would be nice to say what is to be fixed.

> +DOMWrapperWorld* mainThreadNormalWorld()
> +{
> +    return 0;
> +}


> diff --git a/WebCore/bindings/v8/ScriptController.h b/WebCore/bindings/v8/ScriptController.h

> +    // FIXME: Stub method so we compile.  Currently called from
> +    // FrameLoader.cpp.
> +    DOMWrapperWorld* mainThreadNormalWorld();

Why not move this comment inside of the cpp file and just not have it here?
(Is there anything to fix with the prototype?)


> diff --git a/WebCore/dom/Document.cpp b/WebCore/dom/Document.cpp
> +#if USE(JSC)
>      world->rememberDocument(this);
Can this method be implemented (to do nothing) for V8 and then remove this ifdef in the code?

> +#endif
Comment 6 Tony Chang 2009-10-23 11:31:34 PDT
Created attachment 41736 [details]
v2
Comment 7 Tony Chang 2009-10-23 11:32:57 PDT
(In reply to comment #5)
> (From update of attachment 41734 [details])
> > diff --git a/WebCore/bindings/v8/ScriptController.h b/WebCore/bindings/v8/ScriptController.h
> 
> > +    // FIXME: Stub method so we compile.  Currently called from
> > +    // FrameLoader.cpp.
> > +    DOMWrapperWorld* mainThreadNormalWorld();
> 
> Why not move this comment inside of the cpp file and just not have it here?
> (Is there anything to fix with the prototype?)

Done.

> > diff --git a/WebCore/dom/Document.cpp b/WebCore/dom/Document.cpp
> > +#if USE(JSC)
> >      world->rememberDocument(this);
> Can this method be implemented (to do nothing) for V8 and then remove this
> ifdef in the code?
> 
> > +#endif

That would involve implementing |world| (currently, we get by because it's just a pointer that gets passed around).  abarth volunteered to do some cleanup after this.
Comment 8 Adam Barth 2009-10-23 11:38:57 PDT
(In reply to comment #7)
> That would involve implementing |world| (currently, we get by because it's just
> a pointer that gets passed around).  abarth volunteered to do some cleanup
> after this.

We'll implement |world| eventually.  At the moment, the object we use for that has a different lifetime than in JSC, so it will require more surgery than we want to do in this patch.
Comment 9 Tony Chang 2009-10-23 13:16:23 PDT
http://trac.webkit.org/changeset/49992