Bug 30702 – WebKit has no tests containing complex Arabic text

• Status: NEW
• Component: Text

[Evan Martin]

Created attachment 41710 [details]
simple arabic html; will include in a patch as well

I fixed a Chromium-side bug related to the way we handle complex joining characters in Arabic, and I was surprised to discover that no layout tests changed.

We *do* have tests with Hebrew combining characters, but due to subtle details (Hebrew vowels are in the Hebrew class, while Arabic combining characters are in the inherited Unicode class) they were unaffected by my change.

So here's a little bit of Arabic text with some English around it to help hapless observers.

[Evan Martin]

Created attachment 41711 [details]
page + changelog

[Evan Martin]

How do I include a new image baseline?  I have the Mac baseline image here but I'm not sure what to do with it.

[Tony Chang]

(In reply to comment #2)
> How do I include a new image baseline?  I have the Mac baseline image here but
> I'm not sure what to do with it.

svn-create-patch will base64 encode the images into the patch file.  Maybe bugzilla-tool knows how to do that too?

[Eric Seidel (no email)]

bugzilla-tool just uses svn-create-patch under the covers for SVN checkouts. For git checkouts it uses 'git diff' which doesn't really help us, sadly.
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/scm.py

We need to make bugzilla-tool or svn-create-patch know how to make patches for git repositories.

[Evan Martin]

Before I land this, I think I'm going to include some more complicated text just to verify I cover all of the edge cases.

[Eric Seidel (no email)]

Evan?  Should this bug still be open?

[Evan Martin]

Hm, yeah.  I should finish it.  :(

[Ebrahim Byagowi]

Hi, I think someone should add a testcase for joining:
data:text/html;charset=utf-8,<span style="font-size:1000%"><span>%D8%B3</span><span>%D8%B3</span></span>
Please compare it on FF, IE and webkit based browsers.

[Alexey Proskuryakov]

> data:text/html;charset=utf-8,<span style="font-size:1000%"><span>%D8%B3</span><span>%D8%B3</span></span>

That case is tracked in bug 77790 (likely to be duplicate of another older one). It's not a matter of adding a test.

[Evan Martin]

Wow, I have nearly no recollection of filing this bug!

Looking at the patch, it does seem like a useful test baseline.  But it is necessarily an image test, and adding those is both difficult to do for me (haven't set up a build on my Mac in a while) and adds cost to the WebKit project (more images make tests run slower etc.).  So I'm unlikely to finish this.  If someone wants to just close this bug I wouldn't be opposed.