Bug 30698 - createThreadInternal on Android leaks on failure
Summary: createThreadInternal on Android leaks on failure
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Ben Murdoch
Depends on:
Reported: 2009-10-22 17:32 PDT by Steve Block
Modified: 2009-10-23 12:15 PDT (History)
2 users (show)

See Also:

Patch 1 for Bug 30698 (1.23 KB, patch)
2009-10-22 17:53 PDT, Steve Block
dimich: review+
benm: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2009-10-22 17:32:22 PDT
On Android, createThreadInternal leaks an object of type ThreadData on failure.
Comment 1 Steve Block 2009-10-22 17:53:58 PDT
Created attachment 41706 [details]
Patch 1 for Bug 30698
Comment 2 WebKit Commit Bot 2009-10-23 03:01:42 PDT
Comment on attachment 41706 [details]
Patch 1 for Bug 30698

Rejecting patch 41706 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11506 test cases.
fast/media/mq-transform-02.html -> failed

Exiting early after 1 failures. 7441 tests run.
138.55s total testing time

7440 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
3 test cases (<1%) had stderr output
Comment 3 Ben Murdoch 2009-10-23 03:07:28 PDT
Will land manually, looks like https://bugs.webkit.org/show_bug.cgi?id=30700 caused the cq to fail.
Comment 4 Ben Murdoch 2009-10-23 07:09:21 PDT
Landed as r49977.
Comment 5 Eric Seidel (no email) 2009-10-23 12:03:11 PDT
Comment on attachment 41706 [details]
Patch 1 for Bug 30698

Sorry about the commit-queue trouble.  Should work fine now.
Comment 6 Steve Block 2009-10-23 12:11:36 PDT
benm@google.com has already landed this by hand.