Bug 30684 – Makes page reload optional when enabling resource monitoring in InspectorController

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

Created attachment 41673 [details]
Makes page reload optional when enabling resource monitoring in InspectorController

This patch makes page reload optional when enabling resource monitoring in InspectorController.

It is really useful for tools to be able to selectively turn on resource tracking without forcing the page to reload, potentially throwing away application state that is relevant to what you were intended to monitor.

This patch does not change the default behavior (inspecting and activating resource monitoring still triggers page load).

[Timothy Hatcher]

Comment on attachment 41673 [details]
Makes page reload optional when enabling resource monitoring in InspectorController

How is this used?

r- since there are tabs in the ChangeLog. Next time, mark patches for review in Bugzilla to get a review.

Created attachment 41675 [details]
re-adds patch that includes link to this bug in ChangeLog

[Timothy Hatcher]

Comment on attachment 41675 [details]
re-adds patch that includes link to this bug in ChangeLog

> +	InspectorController. It leaves the default behavior as performing the reload.
> +	Reload is an optional param so callsites do not have to change.
> +
> +	Bug link: https://bugs.webkit.org/show_bug.cgi?id=30684

Tabs should be spaces. No need for "Bug link: " prefix.

Created attachment 41676 [details]
removes tabs from ChangeLog

[Pavel Feldman]

This might make us end up in a weird state. Why do you need this? If that is for timeline, I'd suggest adding timeline events into the timeline agent and log there ignoring the enabledResourcesTracking flag. This way you decouple from resources.

[Pavel Feldman]

Comment on attachment 41676 [details]
removes tabs from ChangeLog

I have no better solution to that yet...

[Timothy Hatcher]

(In reply to comment #5)
> This might make us end up in a weird state. Why do you need this? If that is
> for timeline, I'd suggest adding timeline events into the timeline agent and
> log there ignoring the enabledResourcesTracking flag. This way you decouple
> from resources.

I agree. If Timeline wants to show resources they should be tracked seperatly (and likely with less info.)

[WebKit Commit Bot]

Comment on attachment 41676 [details]
removes tabs from ChangeLog

Clearing flags on attachment: 41676

Committed r49954: <http://trac.webkit.org/changeset/49954>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.