Bug 30682 - [Qt] Add Print shortcut to QtLauncher
Summary: [Qt] Add Print shortcut to QtLauncher
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-10-22 11:31 PDT by Girish Ramakrishnan
Modified: 2009-10-22 19:44 PDT (History)
1 user (show)

See Also:


Attachments
[Qt] Add Print Shortcut to QtLauncher (1.22 KB, patch)
2009-10-22 12:20 PDT, Girish Ramakrishnan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Girish Ramakrishnan 2009-10-22 11:31:02 PDT
Add shortcut.
Comment 1 Girish Ramakrishnan 2009-10-22 12:20:51 PDT
Created attachment 41677 [details]
[Qt] Add Print Shortcut to QtLauncher

 WebKit/qt/ChangeLog           |   11 +++++++++++
 WebKit/qt/QtLauncher/main.cpp |    2 +-
 2 files changed, 12 insertions(+), 1 deletions(-)
Comment 2 Eric Seidel (no email) 2009-10-22 12:43:59 PDT
Comment on attachment 41677 [details]
[Qt] Add Print Shortcut to QtLauncher

Looks like this is new as of 4.2.  I'm not sure what version of Qt the QtWebKit folks are trying to target.
http://doc.trolltech.com/4.4/qkeysequence.html#StandardKey-enum

That said, this looks fine as far as I can tell.  This is a debugging tool after all. :)
Comment 3 WebKit Commit Bot 2009-10-22 13:10:19 PDT
Comment on attachment 41677 [details]
[Qt] Add Print Shortcut to QtLauncher

Clearing flags on attachment: 41677

Committed r49953: <http://trac.webkit.org/changeset/49953>
Comment 4 WebKit Commit Bot 2009-10-22 13:10:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Girish Ramakrishnan 2009-10-22 19:44:06 PDT
(In reply to comment #2)
> (From update of attachment 41677 [details])
> Looks like this is new as of 4.2.  I'm not sure what version of Qt the QtWebKit
> folks are trying to target.
> http://doc.trolltech.com/4.4/qkeysequence.html#StandardKey-enum
> 
> That said, this looks fine as far as I can tell.  This is a debugging tool
> after all. :)

We target >= Qt 4.4. Thanks :)