The layout test http/tests/xmlhttprequest/cross-origin-no-authorization.html outputs "DONE" when it has finished running through the whole test. However, currently this is only done if the last test ends with a (caught) error, but not when loading ends regularly.
Created attachment 41650 [details] patch - add "DONE" message when loading ended without an exception This patch adds a "DONE" message when loading ended without an exception (hopefully with a 401 result in that case).
Comment on attachment 41650 [details] patch - add "DONE" message when loading ended without an exception What results does this affect? Why is this needed?
Comment on attachment 41650 [details] patch - add "DONE" message when loading ended without an exception Seems harmless - the test was originally written to allow either outcome, so it should print DONE in both cases. It would be useful to document how you noticed this - did some browser engine you tested have a different behavior? Should we consider changing WebKit behavior?
Comment on attachment 41650 [details] patch - add "DONE" message when loading ended without an exception Roland, I'm pretty sure this is the wrong fix for chromium. Please talk to me for more details.
Comment on attachment 41650 [details] patch - add "DONE" message when loading ended without an exception Rejecting patch 41650 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11484 test cases. fast/media/mq-transform-02.html -> failed Exiting early after 1 failures. 7441 tests run. 143.22s total testing time 7440 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output
Sorry about the commit-queue trouble. Should work fine now.
Fixed with bug 41531 in <http://trac.webkit.org/changeset/63766>. > Roland, I'm pretty sure this is the wrong fix for chromium. Please talk to me for more details. This discussion hasn't been captured in Bugzilla, let's fix whatever problems arise if/when they do.