Bug 30669 - http/tests/xmlhttprequest/cross-origin-no-authorization.html has missing "DONE" in one branch
Summary: http/tests/xmlhttprequest/cross-origin-no-authorization.html has missing "DON...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-22 02:41 PDT by Roland Steiner
Modified: 2010-07-20 12:50 PDT (History)
3 users (show)

See Also:


Attachments
patch - add "DONE" message when loading ended without an exception (1.38 KB, patch)
2009-10-22 02:46 PDT, Roland Steiner
levin: review-
levin: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Steiner 2009-10-22 02:41:45 PDT
The layout test http/tests/xmlhttprequest/cross-origin-no-authorization.html outputs "DONE" when it has finished running through the whole test. However, currently this is only done if the last test ends with a (caught) error, but not when loading ends regularly.
Comment 1 Roland Steiner 2009-10-22 02:46:41 PDT
Created attachment 41650 [details]
patch - add "DONE" message when loading ended without an exception

This patch adds a "DONE" message when loading ended without an exception (hopefully with a 401 result in that case).
Comment 2 Eric Seidel (no email) 2009-10-22 10:42:53 PDT
Comment on attachment 41650 [details]
patch - add "DONE" message when loading ended without an exception

What results does this affect?  Why is this needed?
Comment 3 Alexey Proskuryakov 2009-10-22 17:13:30 PDT
Comment on attachment 41650 [details]
patch - add "DONE" message when loading ended without an exception

Seems harmless - the test was originally written to allow either outcome, so it should print DONE in both cases.

It would be useful to document how you noticed this - did some browser engine you tested have a different behavior? Should we consider changing WebKit behavior?
Comment 4 David Levin 2009-10-22 17:21:03 PDT
Comment on attachment 41650 [details]
patch - add "DONE" message when loading ended without an exception

Roland, I'm pretty sure this is the wrong fix for chromium. Please talk to me for more details.
Comment 5 WebKit Commit Bot 2009-10-22 17:21:16 PDT
Comment on attachment 41650 [details]
patch - add "DONE" message when loading ended without an exception

Rejecting patch 41650 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11484 test cases.
fast/media/mq-transform-02.html -> failed

Exiting early after 1 failures. 7441 tests run.
143.22s total testing time

7440 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
3 test cases (<1%) had stderr output
Comment 6 Eric Seidel (no email) 2009-10-23 12:05:42 PDT
Sorry about the commit-queue trouble.  Should work fine now.
Comment 7 Alexey Proskuryakov 2010-07-20 12:50:49 PDT
Fixed with bug 41531 in <http://trac.webkit.org/changeset/63766>.

> Roland, I'm pretty sure this is the wrong fix for chromium. Please talk to me for more details.

This discussion hasn't been captured in Bugzilla, let's fix whatever problems arise if/when they do.