When high order bit of frame_type is on, it gets length and tries skipping. However, if it has short size of buffer, it failed to skip the length.
Created attachment 41647 [details] Fix WebSocket frame parser of frame_type with high-order bit set.
Comment on attachment 41647 [details] Fix WebSocket frame parser of frame_type with high-order bit set. Why can't we land tests now and just skip them? It's difficult for me to tell what this is doing juts from reading the code.
Comment on attachment 41647 [details] Fix WebSocket frame parser of frame_type with high-order bit set. r- per Eric's comment. Needs a layout test even if it is disabled.
Created attachment 42466 [details] Fix WebSocket frame parser of frame_type with high-order bit set.
Comment on attachment 42466 [details] Fix WebSocket frame parser of frame_type with high-order bit set. I haven't reviewed it completely -- at first glance it looks good. Unfortunately, I'm fairly certain this patch needs to be updated since Yuzo changed some of the same files in a similar manner, so this patch has conflicts now. r- for that.
Created attachment 42941 [details] Fix WebSocket frame parser of frame_type with high-order bit set.
Comment on attachment 42941 [details] Fix WebSocket frame parser of frame_type with high-order bit set. + (): Please remove such artifacts from ChangeLogs. +setTimeout("finish()", 2000); My understanding is that this will not happen in normal case - is that correct? r=me
Committed r50862: <http://trac.webkit.org/changeset/50862>
(In reply to comment #7) > (From update of attachment 42941 [details]) > + (): > > Please remove such artifacts from ChangeLogs. > > +setTimeout("finish()", 2000); > > My understanding is that this will not happen in normal case - is that correct? Yes. In normal case, onclose() will be called soon and finish the test.