Bug 30663 – Web Inspector: windowFocused and windowBlured Fail to Clear/Mark Inspector as "inactive"

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Joseph Pecoraro]

The style class "inactive" is not getting added to the body. It is used numerous times in the CSS.

[Joseph Pecoraro]

Created attachment 41639 [details]
[PATCH] Check document.defaultView

The events are registered on a doc.defaultView:

  doc.defaultView.addEventListener("focus", this.windowFocused.bind(this), true);
  doc.defaultView.addEventListener("blur", this.windowBlured.bind(this), true);

The doc.defaultView is a DOMWindow. Old behavior always fails:

  if (event.target.nodeType === Node.DOCUMENT_NODE)

New behavior tests against the defaultView:

  if (event.target === document.defaultView)

[Joseph Pecoraro]

NOTE TO SELF: the function should be renamed to "windowBlurred" to fix the typo.

[Pavel Feldman]

Comment on attachment 41639 [details]
[PATCH] Check document.defaultView

Fix the Reviewed by :P.

[Joseph Pecoraro]

Landed in http://trac.webkit.org/changeset/49939
r49939 = 4a2c682da0e4de665ca85ef024415a8bdaf830b0

[Timothy Hatcher]

Comment on attachment 41639 [details]
[PATCH] Check document.defaultView

The WebInspector.windowFocused and WebInspector.windowBlured functions are registered on iframes too.

So this will break break for iframes. Try clicking in a Resource source frame, the Inspector should not become "inactive" then.

SourceFrame.js _loaded calls:

        WebInspector.addMainEventListeners(this.element.contentDocument);

[Timothy Hatcher]

Maybe you were seeing it fire twice because you were testing with a source frame?

[Joseph Pecoraro]

Created attachment 41680 [details]
[PATCH] Handle Focus/Blur of inner <iframe>s

Because focus/blur do not tell you _what_ they are focusing on there has to be a bit of co-dependence between the focus/blur:

- Blur runs first, if you're blurring any inner document, always add "inactive"
- Focus runs next, if you're focusing on any inner document, remove "inactive"

Changing useCapture to false no longer fires duplicate blur/focus events.  This was happening when clicking a toolbar (when they were in their :active state). Could be a bug in itself, and may require some investigation.

[Joseph Pecoraro]

(In reply to comment #7)
> Changing useCapture to false no longer fires duplicate blur/focus events.

Oh, this also makes it so event.target is what we expect it to be (doc.defaultView a DOMWindow) so the following should never blow up with an undefined for document:

  event.target.document.nodeType

[Joseph Pecoraro]

Landed Second Patch in http://trac.webkit.org/changeset/49956
r49956 = 3ba0b1d4a6414ecd8dc61d94fe35153b36c04eae