Bug 30657 - video-played.js uses too short of a timeout
Summary: video-played.js uses too short of a timeout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-21 18:52 PDT by Andrew Scherkus
Modified: 2009-10-22 08:53 PDT (History)
2 users (show)

See Also:


Attachments
Round 1 (2.21 KB, patch)
2009-10-21 18:55 PDT, Andrew Scherkus
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Scherkus 2009-10-21 18:52:04 PDT
We have issues running LayoutTest/media/video-played-*.html family of tests because the error timeout is too aggressive.

Since it's based on reaching 10 call counts, tests that use a short delay will result in a tight window to meet the deadline.  For example:
playForMillisecs(100) -> 100 x 10 = 1 second deadline
playForMillisecs(30) -> 30 x 10 = 300 millisecond deadline

I propose letting call counts go wild while measuring the actual time elapsed.
Comment 1 Andrew Scherkus 2009-10-21 18:55:12 PDT
Created attachment 41628 [details]
Round 1

No change to expectations required.  Passing on WebKit Mac.
Comment 2 Eric Carlson 2009-10-22 06:27:57 PDT
Comment on attachment 41628 [details]
Round 1

Nice change, thanks!

r=me
Comment 3 WebKit Commit Bot 2009-10-22 08:53:19 PDT
Comment on attachment 41628 [details]
Round 1

Clearing flags on attachment: 41628

Committed r49941: <http://trac.webkit.org/changeset/49941>
Comment 4 WebKit Commit Bot 2009-10-22 08:53:23 PDT
All reviewed patches have been landed.  Closing bug.