Bug 30636 - [GTK] Double click detection in EventSender DRT is not correct
Summary: [GTK] Double click detection in EventSender DRT is not correct
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-21 10:57 PDT by Alejandro G. Castro
Modified: 2009-10-21 12:03 PDT (History)
1 user (show)

See Also:


Attachments
First patch proposal (1.28 KB, patch)
2009-10-21 11:07 PDT, Alejandro G. Castro
no flags Details | Formatted Diff | Diff
Fixed Changelog comment (1.28 KB, patch)
2009-10-21 11:18 PDT, Alejandro G. Castro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2009-10-21 10:57:10 PDT
It is something like this:

    if (lastClickPositionX != lastMousePositionX && lastClickPositionY != lastMousePositionY)

In my opinioin it should be something like this:

    if (lastClickPositionX != lastMousePositionX || lastClickPositionY != lastMousePositionY)
Comment 1 Alejandro G. Castro 2009-10-21 11:07:08 PDT
Created attachment 41578 [details]
First patch proposal
Comment 2 Alejandro G. Castro 2009-10-21 11:18:00 PDT
Created attachment 41585 [details]
Fixed Changelog comment
Comment 3 Xan Lopez 2009-10-21 11:19:33 PDT
Comment on attachment 41585 [details]
Fixed Changelog comment

Yep.
Comment 4 WebKit Commit Bot 2009-10-21 12:03:37 PDT
Comment on attachment 41585 [details]
Fixed Changelog comment

Clearing flags on attachment: 41585

Committed r49913: <http://trac.webkit.org/changeset/49913>
Comment 5 WebKit Commit Bot 2009-10-21 12:03:40 PDT
All reviewed patches have been landed.  Closing bug.