RESOLVED FIXED 30635
Chromium Linux: disable subpixel text on layers. 
https://bugs.webkit.org/show_bug.cgi?id=30635
Summary Chromium Linux: disable subpixel text on layers.
Adam Langley
Reported 2009-10-21 10:52:15 PDT
http://code.google.com/p/chromium/issues/detail?id=25365 With the addition of layers for drawing rounded corners in r49641, subpixel text on rounded rectangles broke. This is because the layer only contains a single alpha channel and this is insufficient to compose subpixel text correctly. On Windows, a large body of code in TransparencyWin.cpp exists to try to deal with this. Even then, in some cases, it downgrades to anti-aliased text. We need a fix for the grevious effects quickly thus this patch disables subpixel text when rendering into a layer.
Attachments
patch (4.48 KB, patch)
2009-10-21 10:53 PDT, Adam Langley 		no flags
DetailsFormatted DiffDiff
Fix { } around single line branch. (4.47 KB, patch)
2009-10-21 11:07 PDT, Adam Langley 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Langley
Comment 1 2009-10-21 10:53:40 PDT
Created attachment 41574 [details] patch
Eric Seidel (no email)
Comment 2 2009-10-21 10:59:02 PDT
Do we plan to "fix" layers to work with subpixel text at some point? Your patch has extra { } around the single-line if block.
Adam Langley
Comment 3 2009-10-21 11:07:44 PDT
Created attachment 41579 [details] Fix { } around single line branch. Although having 48-bit layers would be interesting, it's never going to happen. A 'better' fix would be to refactor the code in TransparencyWin.cpp and render the text to a side-buffer, manually composing with the underlying layers. However, I'm not sure that I believe that the additional complexity is worth it. Either way, it's certainly not something that I'm going to do before the next dev channel release.
Eric Seidel (no email)
Comment 4 2009-10-21 11:17:53 PDT
Comment on attachment 41579 [details] Fix { } around single line branch. LGTM.
Adam Langley
Comment 5 2009-10-21 11:23:45 PDT
r49909
Note You need to log in before you can comment on or make changes to this bug.