Bug 30632 - bugzilla-tool's "patch failed to download an apply" error should give more information
Summary: bugzilla-tool's "patch failed to download an apply" error should give more in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-21 10:22 PDT by Eric Seidel (no email)
Modified: 2009-10-22 00:03 PDT (History)
4 users (show)

See Also:


Attachments
Make svn-apply failures log to the bug (2.29 KB, patch)
2009-10-21 11:23 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Updated with test case (6.54 KB, patch)
2009-10-21 16:26 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-10-21 10:22:00 PDT
bugzilla-tool's "patch failed to download an apply" error should give more information

https://bugs.webkit.org/show_bug.cgi?id=30435#c9 is one of numerous examples.

Will post a patch shortly.
Comment 1 Eric Seidel (no email) 2009-10-21 11:23:19 PDT
Created attachment 41589 [details]
Make svn-apply failures log to the bug
Comment 2 Adam Barth 2009-10-21 13:42:05 PDT
Comment on attachment 41589 [details]
Make svn-apply failures log to the bug

Unit test?
Comment 3 Eric Seidel (no email) 2009-10-21 16:26:41 PDT
Created attachment 41618 [details]
Updated with test case
Comment 4 Adam Barth 2009-10-21 23:06:53 PDT
Comment on attachment 41618 [details]
Updated with test case

Not what I was expecting you to test, but I'll take it.
Comment 5 WebKit Commit Bot 2009-10-21 23:20:34 PDT
Comment on attachment 41618 [details]
Updated with test case

Clearing flags on attachment: 41618

Committed r49931: <http://trac.webkit.org/changeset/49931>
Comment 6 WebKit Commit Bot 2009-10-21 23:20:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Eric Seidel (no email) 2009-10-21 23:49:56 PDT
Morbid curiosity: what were you expecting me to test?
Comment 8 Adam Barth 2009-10-22 00:03:28 PDT
(In reply to comment #7)
> Morbid curiosity: what were you expecting me to test?

Mostly that bugzilla-tool's "patch failed to download an apply" error should give more information.