Bug 30629 - [Haiku] Issue with accented letters
Summary: [Haiku] Issue with accented letters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-21 07:16 PDT by Maxime Simon
Modified: 2009-10-22 05:06 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.13 KB, patch)
2009-10-21 07:16 PDT, Maxime Simon
no flags Details | Formatted Diff | Diff
Patch v1 (1.77 KB, patch)
2009-10-21 12:26 PDT, Maxime Simon
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Simon 2009-10-21 07:16:12 PDT
Created attachment 41563 [details]
Patch

Accented letters have a twice to big width (problem with unicode).

The function SimpleFontData::platformWidthForGlyph(Glyph) is wrongly
implemented. So I reused charUnicodeToUTF8HACK(unsigned short, char*)
from WebCore/platform/graphics/haiku/FontHaiku.cpp .

Regards,
Maxime
Comment 1 Eric Seidel (no email) 2009-10-21 10:28:44 PDT
Comment on attachment 41563 [details]
Patch

This needs a ChangeLog with explanation of what this is doing.
Comment 2 Maxime Simon 2009-10-21 12:26:06 PDT
Created attachment 41600 [details]
Patch v1
Comment 3 Holger Freyther 2009-10-22 04:44:02 PDT
Comment on attachment 41600 [details]
Patch v1

Have you considered using the UTF8 Encoder of WebCore instead of your custom conversion routine? "hack" somehow indicates that this is an interim solution?
Comment 4 WebKit Commit Bot 2009-10-22 04:52:59 PDT
Comment on attachment 41600 [details]
Patch v1

Clearing flags on attachment: 41600

Committed r49937: <http://trac.webkit.org/changeset/49937>
Comment 5 WebKit Commit Bot 2009-10-22 04:53:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Maxime Simon 2009-10-22 05:06:05 PDT
(In reply to comment #3)
> (From update of attachment 41600 [details])
> Have you considered using the UTF8 Encoder of WebCore instead of your custom
> conversion routine? "hack" somehow indicates that this is an interim solution?

Actually we use this "hack" function in two different places of our code. But indeed I should investigate on using UTF8 Encoder. Thanks.