Bug 306289 – [OpenXR] REGRESSION(305928@main): Build fails with ENABLE_WEBXR_HIT_TEST=OFF

• Status: RESOLVED
• Resolution: FIXED
• Component: WebXR

[Adrian Perez]

Reproducible with ”./Tools/Scripts/build-webkit --wpe --cmakeargs=-DENABLE_WEBXR_HIT_TEST=OFF”:

In file included from /sdk/webkit/WebKitBuild/WPE/Release/DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-36.cpp:4:
/sdk/webkit/Source/WebKit/UIProcess/XR/openxr/PlatformXROpenXR.cpp:977:28: error: use of undeclared identifier 'm_viewerSpace'; did you mean 'm_floorSpace'?
  977 |     viewLocateInfo.space = m_viewerSpace;
      |                            ^~~~~~~~~~~~~
      |                            m_floorSpace
/sdk/webkit/Source/WebKit/UIProcess/XR/openxr/PlatformXROpenXR.h:139:13: note: 'm_floorSpace' declared here
  139 |     XrSpace m_floorSpace { XR_NULL_HANDLE };
      |             ^
In file included from /sdk/webkit/WebKitBuild/WPE/Release/DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-36.cpp:4:
/sdk/webkit/Source/WebKit/UIProcess/XR/openxr/PlatformXROpenXR.cpp:992:31: error: use of undeclared identifier 'm_viewerSpace'; did you mean 'm_floorSpace'?
  992 |     CHECK_XRCMD(xrLocateSpace(m_viewerSpace, m_localSpace, renderState->frameState.predictedDisplayTime, &originLocation));
      |                               ^~~~~~~~~~~~~
      |                               m_floorSpace
/sdk/webkit/Source/WebKit/UIProcess/XR/openxr/OpenXRUtils.h:72:40: note: expanded from macro 'CHECK_XRCMD'
   72 | #define CHECK_XRCMD(cmd) checkXrResult(cmd, #cmd, FILE_AND_LINE);
      |                                        ^
/sdk/webkit/Source/WebKit/UIProcess/XR/openxr/PlatformXROpenXR.h:139:13: note: 'm_floorSpace' declared here
  139 |     XrSpace m_floorSpace { XR_NULL_HANDLE };
      |             ^
2 errors generated.

[Sergio Villar Senin]

Pull request: https://github.com/WebKit/WebKit/pull/57475

[EWS]

Committed 306423@main (1ce66573af78): <https://commits.webkit.org/306423@main>

Reviewed commits have been landed. Closing PR #57475 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/169192551>