The menu key (this one: http://en.wikipedia.org/wiki/Menu_key) doesn't work in Linux. Shift+F10 also doesn't. Both should emulate right click. * If focus is in a text field, it should be the same as right clicking where the text cursor is (this currently DOES work in the omnibox, but not other text fields) * If focus is on another element (like a link) it should bring up the context menu for that next to it. * If text is selected, Firefox brings up the context menu for that text in the upper right hand corner of the page, but I think it would be better for it to appear next to the selected text. But that might be hard. * If focus is not on anything else, it should bring up the page's context menu in the upper left hand corner of the page Original chromium bug tracker: http://code.google.com/p/chromium/issues/detail?id=18232 bug #28247 also partly refers this bug.
Created attachment 41557 [details] Fix for bug 30619: Menu key doesn't work on Linux
The change looks good to me, but I'm not a WebKit reviewer so I can't give you an official review. It would be nice if we could have tests for this.
You might be able to add a layout test for this by extending eventSender.keyDown() to know about the menu key. Note that this still wouldn't show up in a pixel test result because context menus are a different window, so perhaps it's not worth the effort.
Comment on attachment 41557 [details] Fix for bug 30619: Menu key doesn't work on Linux We could definitely have a manual-test for this. WebCore/manual-tests/ Otherwise this looks fine.
(In reply to comment #1) > Created an attachment (id=41557) [details] > Fix for bug 30619: Menu key doesn't work on Linux Would be nice if we can update WebCore/platform/gtk/KeyEventGtk.cpp as well.
Created attachment 41651 [details] Added manual test for Menu key event.
Created attachment 41655 [details] Hi, I added a manual test and also updated platform/gtk/KeyEventGtk.cpp. In this patch I haven't extended eventSender.keyDown() for now.
Comment on attachment 41655 [details] Hi, I added a manual test and also updated platform/gtk/KeyEventGtk.cpp. In this patch I haven't extended eventSender.keyDown() for now. > + No new tests: testing this will require changes in the test > + controller in a platform-specific way. (Mac doesn't have Menu key) Would be nice to mention that there's a manual test for this. Regardles, LGTM. r=me.
(In reply to comment #8) > (From update of attachment 41655 [details]) > > + No new tests: testing this will require changes in the test > > + controller in a platform-specific way. (Mac doesn't have Menu key) > > Would be nice to mention that there's a manual test for this. > > Regardles, LGTM. r=me. Thanks for reviewing! I'm updating the ChangeLog in the following patch. Could you review it one more time? (Hope it'll be the last one.) Thanks,
Created attachment 41844 [details] Fix for bug 30619: Menu key doesn't work on Linux
Comment on attachment 41844 [details] Fix for bug 30619: Menu key doesn't work on Linux Clearing flags on attachment: 41844 Committed r50051: <http://trac.webkit.org/changeset/50051>
All reviewed patches have been landed. Closing bug.