Bug 30616 - REGRESSION (r49036): Web Inspector: Summary graph no longer switching to size summary
Summary: REGRESSION (r49036): Web Inspector: Summary graph no longer switching to size...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Weinstein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-20 21:05 PDT by Timothy Hatcher
Modified: 2009-10-21 12:55 PDT (History)
6 users (show)

See Also:


Attachments
Screenshoot of the bug (37.79 KB, image/png)
2009-10-21 11:06 PDT, Timothy Hatcher
no flags Details
Expected (85.96 KB, image/png)
2009-10-21 11:07 PDT, Timothy Hatcher
no flags Details
Fix (1.82 KB, patch)
2009-10-21 12:12 PDT, Brian Weinstein
timothy: review+
bweinstein: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2009-10-20 21:05:23 PDT
When looking at Resources time graph, switching to size graph no longer shows the size summary graph.
Comment 1 Timothy Hatcher 2009-10-21 11:06:43 PDT
Created attachment 41577 [details]
Screenshoot of the bug
Comment 2 Timothy Hatcher 2009-10-21 11:07:51 PDT
Created attachment 41580 [details]
Expected
Comment 3 Brian Weinstein 2009-10-21 12:12:55 PDT
Created attachment 41597 [details]
Fix
Comment 4 Timothy Hatcher 2009-10-21 12:50:11 PDT
Comment on attachment 41597 [details]
Fix

Just do: if (this.calculator.startAtZero || !this.calculator.computePercentageFromEventTime)
Comment 5 Brian Weinstein 2009-10-21 12:55:03 PDT
Committed in http://trac.webkit.org/changeset/49919.