Bug 306129 – [GTK] error: call to 'gst_check_version' is ambiguous

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Jeremy Bicha]

- webkitgtk 2.51.90
- gstreamer 1.27.90
- Ubuntu 26.04 LTS devel

webkitgtk is failing to build in Ubuntu 26.04 LTS which already has gstreamer 1.27.90. I expect gstreamer 1.28.0 to be released next week.

It looks like https://github.com/WebKit/WebKit/pull/53872 needs to be fixed.

Build excerpt
==========
In file included from /<<PKGBUILDDIR>>/build-gtk3/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-56.cpp:2:
/<<PKGBUILDDIR>>/Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:72:14: error: call to 'gst_check_version' is ambiguous
   72 |         if (!gst_check_version(1, 20, 0))
      |              ^~~~~~~~~~~~~~~~~
/usr/include/gstreamer-1.0/gst/gst.h:134:17: note: candidate function
  134 | gboolean        gst_check_version               (guint major, guint minor, guint micro);
      |                 ^
/<<PKGBUILDDIR>>/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:62:13: note: candidate function
   62 | inline bool gst_check_version(guint major, guint minor, guint micro)
      |             ^
1 error generated.
[8647/9439]

Build log
=======
https://launchpad.net/~jbicha/+archive/ubuntu/arch/+build/32183464

[Philippe Normand]

If you really have GStreamer 1.27.90 I don't see how the WebKit gst_check_version is picked-up, it should be only for versions < 1.27.2.1.

[Philippe Normand]

That was fixed in https://bugs.webkit.org/show_bug.cgi?id=302779 ... do you have that commit?

[Jeremy Bicha]

Yes, that commit is included and yes, the build logs show that gstreamer 1.27.90 is being used.

https://github.com/WebKit/WebKit/pull/54175

[Philippe Normand]

The GST_CHECK_VERSION_FULL macro is incorrect, it would need to be more elaborate... I'll just remove it for now, since we can check for 1.27.90 now that it is out.

[Philippe Normand]

Pull request: https://github.com/WebKit/WebKit/pull/57171

[Jeremy Bicha]

I confirm that pull request fixes my issue.

[EWS]

Committed 306164@main (6ab4390e676d): <https://commits.webkit.org/306164@main>

Reviewed commits have been landed. Closing PR #57171 and removing active labels.