Bug 30611 - Fix the crash when a node not in a document receives dispatchEvent.
Summary: Fix the crash when a node not in a document receives dispatchEvent.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-20 17:36 PDT by Dmitry Titov
Modified: 2009-10-21 11:35 PDT (History)
1 user (show)

See Also:

Attachments
Proposed patch. (3.59 KB, patch)
2009-10-20 17:52 PDT, Dmitry Titov 		darin: review+
dimich: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Titov 2009-10-20 17:36:06 PDT 
The node that doesn't have a document (easy to repro with documentType node which is just created) crashes while trying to dispatchEvent.
FireFox in similar scenario simply treats dispatchEvent() as noop. We should do the same. Patch is coming.
Comment 1 Dmitry Titov 2009-10-20 17:52:55 PDT 
Created attachment 41539 [details]
Proposed patch.
Comment 2 Darin Adler 2009-10-20 23:53:47 PDT 
Comment on attachment 41539 [details]
Proposed patch.

r=me
Comment 3 Dmitry Titov 2009-10-21 11:35:08 PDT 
Landed: http://trac.webkit.org/changeset/49911