Bug 30610 - Fix click-focus-anchor test
Summary: Fix click-focus-anchor test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-20 17:21 PDT by Victor Wang
Modified: 2009-10-21 12:11 PDT (History)
3 users (show)

See Also:


Attachments
Proposed Patch (1.26 KB, patch)
2009-10-20 17:24 PDT, Victor Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Wang 2009-10-20 17:21:07 PDT
LayoutTests/fast/events/click-focus-anchor.html is missing mouseUp events. Should be fixed to mimic "click" behavior.
Comment 1 Victor Wang 2009-10-20 17:24:07 PDT
Created attachment 41538 [details]
Proposed Patch
Comment 2 Adele Peterson 2009-10-20 17:25:32 PDT
Is there any effect any any form of the expected results?
Comment 3 Victor Wang 2009-10-20 17:30:21 PDT
It fails on chromium test because the current events more like drag not click.
The expectation results are fine.
Comment 4 Eric Seidel (no email) 2009-10-21 10:33:16 PDT
Comment on attachment 41538 [details]
Proposed Patch

Looks fine. Seems Chromium's test_shell may have more issues like this.  Seeting cq+ since Victor is not a committer.
Comment 5 WebKit Commit Bot 2009-10-21 10:35:47 PDT
Comment on attachment 41538 [details]
Proposed Patch

Rejecting patch 41538 from commit-queue.

Failed to run "['git', 'svn', 'rebase']" exit_code: 1
RA layer request failed: PROPFIND request failed on '/repository/webkit': PROPFIND of '/repository/webkit': could not connect to server (http://svn.webkit.org) at /usr/local/libexec/git-core//git-svn line 1909
Comment 6 Victor Wang 2009-10-21 11:56:06 PDT
Eric,

Looks like the commit bot failed to land this patch, could you check?

Thanks,
Victor
Comment 7 Eric Seidel (no email) 2009-10-21 12:00:00 PDT
Comment on attachment 41538 [details]
Proposed Patch

I'm not sure what would cause that.  I'm also not sure if the commit-queue should spin in that instance or fail like it did here.  Let's just add it back to the queue.
Comment 8 WebKit Commit Bot 2009-10-21 12:11:04 PDT
Comment on attachment 41538 [details]
Proposed Patch

Clearing flags on attachment: 41538

Committed r49914: <http://trac.webkit.org/changeset/49914>
Comment 9 WebKit Commit Bot 2009-10-21 12:11:08 PDT
All reviewed patches have been landed.  Closing bug.