RESOLVED FIXED 30610
Fix click-focus-anchor test 
https://bugs.webkit.org/show_bug.cgi?id=30610
Summary Fix click-focus-anchor test
Victor Wang
Reported 2009-10-20 17:21:07 PDT
LayoutTests/fast/events/click-focus-anchor.html is missing mouseUp events. Should be fixed to mimic "click" behavior.
Attachments
Proposed Patch (1.26 KB, patch)
2009-10-20 17:24 PDT, Victor Wang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Victor Wang
Comment 1 2009-10-20 17:24:07 PDT
Created attachment 41538 [details] Proposed Patch
Adele Peterson
Comment 2 2009-10-20 17:25:32 PDT
Is there any effect any any form of the expected results?
Victor Wang
Comment 3 2009-10-20 17:30:21 PDT
It fails on chromium test because the current events more like drag not click. The expectation results are fine.
Eric Seidel (no email)
Comment 4 2009-10-21 10:33:16 PDT
Comment on attachment 41538 [details] Proposed Patch Looks fine. Seems Chromium's test_shell may have more issues like this. Seeting cq+ since Victor is not a committer.
WebKit Commit Bot
Comment 5 2009-10-21 10:35:47 PDT
Comment on attachment 41538 [details] Proposed Patch Rejecting patch 41538 from commit-queue. Failed to run "['git', 'svn', 'rebase']" exit_code: 1 RA layer request failed: PROPFIND request failed on '/repository/webkit': PROPFIND of '/repository/webkit': could not connect to server (http://svn.webkit.org) at /usr/local/libexec/git-core//git-svn line 1909
Victor Wang
Comment 6 2009-10-21 11:56:06 PDT
Eric, Looks like the commit bot failed to land this patch, could you check? Thanks, Victor
Eric Seidel (no email)
Comment 7 2009-10-21 12:00:00 PDT
Comment on attachment 41538 [details] Proposed Patch I'm not sure what would cause that. I'm also not sure if the commit-queue should spin in that instance or fail like it did here. Let's just add it back to the queue.
WebKit Commit Bot
Comment 8 2009-10-21 12:11:04 PDT
Comment on attachment 41538 [details] Proposed Patch Clearing flags on attachment: 41538 Committed r49914: <http://trac.webkit.org/changeset/49914>
WebKit Commit Bot
Comment 9 2009-10-21 12:11:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.