Bug 30605 – Unsupported attribute set on QGraphicsWebView

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Kenneth Rohde Christiansen]

Using Qt 4.6 trunk and the QGraphicsWebView I get a lot of error output like:

QGraphicsWidget::setAttribute: unsupported attribute 14                                            

According to Qt docs, 14 is the Qt::WA_InputMethodEnabled which is indeed being set:

WebKit/qt/Api/qgraphicswebview.cpp:    q->setAttribute(Qt::WA_InputMethodEnabled, enable);

This line doesn't seem to be doing what it is supposed to, so either it should be replaced or Qt should be fixed to make it work.

[Simon Hausmann]

Right, it's calling the wrong method, it should be calling QGraphicsItem::setItemFlag instead with ItemAcceptsInputMethod. I'm preparing a patch.

[Simon Hausmann]

Created attachment 42302 [details]
[Qt] Fix enabling of input method support on QGraphicsWebView.

[Holger Freyther]

Comment on attachment 42302 [details]
[Qt] Fix enabling of input method support on QGraphicsWebView.

Looks good... I wonder if you want to call setGeometry on the QWebView too?

[WebKit Commit Bot]

Comment on attachment 42302 [details]
[Qt] Fix enabling of input method support on QGraphicsWebView.

Rejecting patch 42302 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Holger Freyther', '--force']" exit_code: 1
patching file WebKit/qt/Api/qgraphicswebview.cpp
Hunk #1 FAILED at 105.
1 out of 1 hunk FAILED -- saving rejects to file WebKit/qt/Api/qgraphicswebview.cpp.rej
patching file WebKit/qt/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/qt/tests/qwebpage/tst_qwebpage.cpp
Hunk #1 FAILED at 21.
Hunk #2 FAILED at 123.
Hunk #3 FAILED at 1266.
Hunk #4 FAILED at 1346.
Hunk #5 FAILED at 1395.
5 out of 5 hunks FAILED -- saving rejects to file WebKit/qt/tests/qwebpage/tst_qwebpage.cpp.rej

[Eric Seidel (no email)]

Looks like this was landed as r50551 but just not closed. :(