Bug 30605 - Unsupported attribute set on QGraphicsWebView
Summary: Unsupported attribute set on QGraphicsWebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Simon Hausmann
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-10-20 16:05 PDT by Kenneth Rohde Christiansen
Modified: 2009-11-09 17:31 PST (History)
2 users (show)

See Also:


Attachments
[Qt] Fix enabling of input method support on QGraphicsWebView. (9.30 KB, patch)
2009-11-01 22:39 PST, Simon Hausmann
zecke: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2009-10-20 16:05:45 PDT
Using Qt 4.6 trunk and the QGraphicsWebView I get a lot of error output like:

QGraphicsWidget::setAttribute: unsupported attribute 14                                            

According to Qt docs, 14 is the Qt::WA_InputMethodEnabled which is indeed being set:

WebKit/qt/Api/qgraphicswebview.cpp:    q->setAttribute(Qt::WA_InputMethodEnabled, enable);

This line doesn't seem to be doing what it is supposed to, so either it should be replaced or Qt should be fixed to make it work.
Comment 1 Simon Hausmann 2009-11-01 19:58:38 PST
Right, it's calling the wrong method, it should be calling QGraphicsItem::setItemFlag instead with ItemAcceptsInputMethod. I'm preparing a patch.
Comment 2 Simon Hausmann 2009-11-01 22:39:09 PST
Created attachment 42302 [details]
[Qt] Fix enabling of input method support on QGraphicsWebView.
Comment 3 Holger Freyther 2009-11-07 01:11:44 PST
Comment on attachment 42302 [details]
[Qt] Fix enabling of input method support on QGraphicsWebView.

Looks good... I wonder if you want to call setGeometry on the QWebView too?
Comment 4 WebKit Commit Bot 2009-11-09 17:16:32 PST
Comment on attachment 42302 [details]
[Qt] Fix enabling of input method support on QGraphicsWebView.

Rejecting patch 42302 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Holger Freyther', '--force']" exit_code: 1
patching file WebKit/qt/Api/qgraphicswebview.cpp
Hunk #1 FAILED at 105.
1 out of 1 hunk FAILED -- saving rejects to file WebKit/qt/Api/qgraphicswebview.cpp.rej
patching file WebKit/qt/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/qt/tests/qwebpage/tst_qwebpage.cpp
Hunk #1 FAILED at 21.
Hunk #2 FAILED at 123.
Hunk #3 FAILED at 1266.
Hunk #4 FAILED at 1346.
Hunk #5 FAILED at 1395.
5 out of 5 hunks FAILED -- saving rejects to file WebKit/qt/tests/qwebpage/tst_qwebpage.cpp.rej
Comment 5 Eric Seidel (no email) 2009-11-09 17:31:44 PST
Looks like this was landed as r50551 but just not closed. :(