Bug 30591 - Make Chromium Mac pasteboard code flow like other platforms
Summary: Make Chromium Mac pasteboard code flow like other platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-20 12:36 PDT by Avi Drissman
Modified: 2009-10-22 10:49 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.47 KB, patch)
2009-10-20 12:38 PDT, Avi Drissman 		eric: review+
avi: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Avi Drissman 2009-10-20 12:36:40 PDT 
Right now the Chromium Mac pasteboard code is unimplemented. This is the WebCore side of the patch (the Chromium side is http://codereview.chromium.org/308001).
Comment 1 Avi Drissman 2009-10-20 12:38:14 PDT 
Created attachment 41517 [details]
Patch
Comment 2 Eric Seidel (no email) 2009-10-20 23:16:05 PDT 
Comment on attachment 41517 [details]
Patch

LGTM.  Darin should see this go by, I'll CC him.

Seems a little odd for ChromiumBridge.h to include ImageSource.h, but OK.
Comment 3 Avi Drissman 2009-10-21 12:02:22 PDT 
I tried to mark the patch as Darin's for review but there was no edit box. Is that something new?
Comment 4 Eric Seidel (no email) 2009-10-21 12:16:03 PDT 
You should subscribe to webkit-dev if you aren't already. :)
https://lists.webkit.org/pipermail/webkit-dev/2009-October/010091.html
Comment 5 Darin Fisher (:fishd, Google) 2009-10-21 16:41:18 PDT 
r=me
Comment 6 Andrew Wilson 2009-10-22 10:49:42 PDT 
landed as r49946