Bug 30589 - [GTK] Failing media/video-played-reset.html
Summary: [GTK] Failing media/video-played-reset.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-20 11:59 PDT by Xan Lopez
Modified: 2009-11-02 12:14 PST (History)
1 user (show)

See Also:


Attachments
proposed patch (3.15 KB, patch)
2009-11-02 09:51 PST, Philippe Normand
no flags Details | Formatted Diff | Diff
unskip fixed test (1.40 KB, patch)
2009-11-02 09:51 PST, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2009-10-20 11:59:32 PDT
Seems to jump between failing and timing out.
Comment 1 Philippe Normand 2009-11-02 09:51:00 PST
Created attachment 42321 [details]
proposed patch

Our GStreamer-based player does seeking by sending a seek event to playbin2. Current position is not immediately updated so we can end up in a state where currentTime() is called while a seek is in progress. The patch adds a new private attribute in the player class, used to cache the seek time position during seeking so currentTime reports the correct position.
Comment 2 Philippe Normand 2009-11-02 09:51:58 PST
Created attachment 42322 [details]
unskip fixed test
Comment 3 Jan Alonzo 2009-11-02 11:15:22 PST
Comment on attachment 42321 [details]
proposed patch

r=me.
Comment 4 WebKit Commit Bot 2009-11-02 11:34:24 PST
Comment on attachment 42321 [details]
proposed patch

Clearing flags on attachment: 42321

Committed r50424: <http://trac.webkit.org/changeset/50424>
Comment 5 WebKit Commit Bot 2009-11-02 12:14:42 PST
Comment on attachment 42322 [details]
unskip fixed test

Clearing flags on attachment: 42322

Committed r50425: <http://trac.webkit.org/changeset/50425>
Comment 6 WebKit Commit Bot 2009-11-02 12:14:45 PST
All reviewed patches have been landed.  Closing bug.