RESOLVED FIXED 30578
WebInspector: Adds XHR Instrumentation to WebInspector Timeline 
https://bugs.webkit.org/show_bug.cgi?id=30578
Summary WebInspector: Adds XHR Instrumentation to WebInspector Timeline
Eric Ayers
Reported 2009-10-20 10:09:54 PDT
This change instruments XMLHttpRequest.cpp so that any ready state change or load events are forwarded to the Timeline Inpsector Agent.
Attachments
WebInspector: adds XHR instrumentation to XMLHttpRequest for the TimelineAgent (26.68 KB, patch)
2009-10-20 10:57 PDT, Eric Ayers 		pfeldman: review-
DetailsFormatted DiffDiff
Updates original patch after recent changes. (7.70 KB, patch)
2009-10-27 11:40 PDT, Kelly Norton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Ayers
Comment 1 2009-10-20 10:57:56 PDT
Created attachment 41513 [details] WebInspector: adds XHR instrumentation to XMLHttpRequest for the TimelineAgent
Eric Ayers
Comment 2 2009-10-20 13:59:40 PDT
Note: This patch conflicts with 30600. Which ever patch lands first, the other will need to be modified before committing.
Pavel Feldman
Comment 3 2009-10-20 15:51:18 PDT
Comment on attachment 41513 [details] WebInspector: adds XHR instrumentation to XMLHttpRequest for the TimelineAgent Given that you require frontend to be present at all times timeline events are fired, there is no need to create native structures for all of your event types. Just dump them into the frontend using some static serializer methods. You should be able to get rid of them all together actually (*TimelineItem).
Eric Ayers
Comment 4 2009-10-20 23:07:54 PDT
Some info for reference only: Patch 30600 landed. Pavel's comments are explained in more detail at https://bugs.webkit.org/show_bug.cgi?id=30467#attach_41335 Original code review for adding these instrumentation points: https://bugs.webkit.org/show_bug.cgi?id=25503
Kelly Norton
Comment 5 2009-10-27 11:40:20 PDT
Created attachment 41969 [details] Updates original patch after recent changes.
WebKit Commit Bot
Comment 6 2009-10-27 12:31:07 PDT
Comment on attachment 41969 [details] Updates original patch after recent changes. Clearing flags on attachment: 41969 Committed r50167: <http://trac.webkit.org/changeset/50167>
WebKit Commit Bot
Comment 7 2009-10-27 12:31:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.