Bug 30572 – Unification of using null device in perl scripts

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

To use a really platform independent perl scripts we mustn't use /dev/null as null device.
In perl there is File::Spec->devnull() to determine platorm dependent null device.

I prefer using File::Spec->devnull() everywhere. But there are few 
place, where the shell command is in `...`. (VCSUtils.pm and bisect-builds)  
In these files we can use this method:

my $devNull = File::Spec->devnull();
`... $devNull ...`

[Csaba Osztrogonác]

Created attachment 41507 [details]
proposed patch

[Eric Seidel (no email)]

Comment on attachment 41507 [details]
proposed patch

I believe our style is to put spaces around '.' operators.

Also, I'm surprised that sometimes you use local variables to hold $devNull and sometimes you make direct calls to File::Spec->devnull().

Is devnull() always a string path?

[Csaba Osztrogonác]

(In reply to comment #2)
> I believe our style is to put spaces around '.' operators.
Yes, you're right, sorry. I will correct it.
 
> Also, I'm surprised that sometimes you use local variables to hold $devNull
> and sometimes you make direct calls to File::Spec->devnull().
I told I prefer using File::Spec->devnull() everywhere, but I have no idea how could I use it directly in `...`. Accordingly I use local variable same as in svn-create-patch originally. Have you got better idea to solve this problem?
 
> Is devnull() always a string path?
You can find devNull() here: http://perldoc.perl.org/File/Spec.html
"Returns a string representation of the null device."
It works correctly, we used it previosly in WebKit scripts.

[Csaba Osztrogonác]

(In reply to comment #2)
> I believe our style is to put spaces around '.' operators.
Yes, you're right, sorry. I will correct it.
 
> Also, I'm surprised that sometimes you use local variables to hold $devNull
> and sometimes you make direct calls to File::Spec->devnull().
I told I prefer using File::Spec->devnull() everywhere, but I have no idea how could I use it directly in `...`. Accordingly I use local variable same as in svn-create-patch originally. Have you got better idea to solve this problem?
 
> Is devnull() always a string path?
You can find devNull() here: http://perldoc.perl.org/File/Spec.html
"Returns a string representation of the null device."
It works correctly, we used it previosly in WebKit scripts.

[Csaba Osztrogonác]

(In reply to comment #2)
> (From update of attachment 41507 [details])
> I believe our style is to put spaces around '.' operators.
Updated.

> Also, I'm surprised that sometimes you use local variables to hold $devNull and
> sometimes you make direct calls to File::Spec->devnull().
I modified bisect-builds, we can use exec instead of backstick operator.

But I have no idea what should we do with backstick of svn-create-patch:
    print `svn cat ${sourceFile} | diff -u $devNull - | tail -n +3`;

We can't use system or exec insted of backsticks. 
I think we shouldn't rewrite this code at any price.

[Csaba Osztrogonác]

Created attachment 41876 [details]
proposed patch

[Eric Seidel (no email)]

CCing perl folks, as I am not one.

[Csaba Osztrogonác]

Thx for review.

Sending        WebKitTools/ChangeLog
Sending        WebKitTools/Scripts/VCSUtils.pm
Sending        WebKitTools/Scripts/bisect-builds
Sending        WebKitTools/Scripts/resolve-ChangeLogs
Sending        WebKitTools/Scripts/run-iexploder-tests
Sending        WebKitTools/Scripts/run-jsc
Sending        WebKitTools/Scripts/run-mangleme-tests
Sending        WebKitTools/Scripts/run-webkit-tests
Sending        WebKitTools/Scripts/webkitdirs.pm
Transmitting file data .........
Committed revision 50080.

[David Kilzer (:ddkilzer)]

This broke the bisect-builds script.  See Bug 31840.