Bug 30570 - The op_next_pname should use 4 bytes addressing mode in case of JSValue32
Summary: The op_next_pname should use 4 bytes addressing mode in case of JSValue32
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-20 06:57 PDT by Gabor Loki
Modified: 2009-10-20 11:41 PDT (History)
2 users (show)

See Also:


Attachments
The op_next_pname should use 4 bytes addressing mode in case of JSValue32 (1.58 KB, patch)
2009-10-20 06:58 PDT, Gabor Loki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Loki 2009-10-20 06:57:32 PDT
The changeset 49734 introduced a bug in JSValue32.

In emit_op_next_pname function the addressing mode to access key @i should be use 4 bytes instead of 8 bytes. I seems like a copy-paste error.
Comment 1 Gabor Loki 2009-10-20 06:58:26 PDT
Created attachment 41505 [details]
The op_next_pname should use 4 bytes addressing mode in case of JSValue32
Comment 2 Geoffrey Garen 2009-10-20 11:27:29 PDT
Comment on attachment 41505 [details]
The op_next_pname should use 4 bytes addressing mode in case of JSValue32

Oops! Thanks.
Comment 3 WebKit Commit Bot 2009-10-20 11:41:48 PDT
Comment on attachment 41505 [details]
The op_next_pname should use 4 bytes addressing mode in case of JSValue32

Clearing flags on attachment: 41505

Committed r49874: <http://trac.webkit.org/changeset/49874>
Comment 4 WebKit Commit Bot 2009-10-20 11:41:52 PDT
All reviewed patches have been landed.  Closing bug.